Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libzippp] Update to libzippp 5.1-1.8.0 #24885

Merged
merged 1 commit into from
May 25, 2022

Conversation

ctabin
Copy link
Contributor

@ctabin ctabin commented May 23, 2022

Upgrade to the latest version of libzippp.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

Use the version scheme "version" instead of "version-string" in port "libzippp".

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 840f701d83d5019aa5033c9d9d08a4cc0d0ebdce -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
old mode 100755
new mode 100644
index ec4cbe9..a18c4de
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4229,7 +4229,7 @@
       "port-version": 0
     },
     "libzippp": {
-      "baseline": "5.0-1.8.0",
+      "baseline": "5.1-1.8.0",
       "port-version": 1
     },
     "licensepp": {

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libzippp/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the version scheme "version" instead of "version-string" in port "libzippp".

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libzippp/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 24, 2022
@JonLiu1993
Copy link
Member

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

Use the version scheme "version" instead of "version-string" in port "libzippp".

After committing all other changes, the version database must be updated
You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions: vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake) vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake) vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake) vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libzippp/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

@ctabin ,Thanks for your pr, could you please modernize your portfile.cmake according to the above tips?

ports/libzippp/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/libzippp/vcpkg.json b/ports/libzippp/vcpkg.json
index f5d282d..7cbc819 100644
--- a/ports/libzippp/vcpkg.json
+++ b/ports/libzippp/vcpkg.json
@@ -11,7 +11,6 @@
         "bzip2"
       ]
     },
-    "zlib",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -19,7 +18,8 @@
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
+    },
+    "zlib"
   ],
   "features": {
     "encryption": {

Use the version scheme "version" instead of "version-string" in port "libzippp".

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 6a66e95caad0c880393cd0b99dc0edecd7d7a751 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index b57420e..5e5beaa 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4230,7 +4230,7 @@
     },
     "libzippp": {
       "baseline": "5.1-1.8.0",
-      "port-version": 1
+      "port-version": 0
     },
     "licensepp": {
       "baseline": "2020-05-19",
diff --git a/versions/l-/libzippp.json b/versions/l-/libzippp.json
index 1f3df1f..113055b 100644
--- a/versions/l-/libzippp.json
+++ b/versions/l-/libzippp.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3e96bc8637a90287ec51dd8e1ac4705644ec6845",
+      "version-string": "5.1-1.8.0",
+      "port-version": 0
+    },
     {
       "git-tree": "334283c23b15b248063b9bcbe8295a3f7e85ef80",
       "version-string": "5.1-1.8.0",

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libzippp have changed but the version was not updated
version: 5.1-1.8.0
old SHA: 334283c23b15b248063b9bcbe8295a3f7e85ef80
new SHA: 7cc03f961e9bbe1f50b6af953e173ad01f61b663
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

@ctabin ctabin requested a review from JonLiu1993 May 24, 2022 20:50
ports/libzippp/portfile.cmake Outdated Show resolved Hide resolved
ports/libzippp/portfile.cmake Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libzippp have changed but the version was not updated
version: 5.1-1.8.0
old SHA: 7cc03f961e9bbe1f50b6af953e173ad01f61b663
new SHA: 0e5a10e0beabc7b9a1f9f313e62a1c73833e1c4f
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libzippp/vcpkg.json

Valid values for the license field can be found in the documentation

@ctabin ctabin requested review from JonLiu1993 and removed request for JonLiu1993 May 25, 2022 06:28
@JonLiu1993
Copy link
Member

Feature "encryption" tested successfully in the following triplet:

  • x86-windows
  • x64-widnows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 25, 2022
@ras0219-msft ras0219-msft merged commit 24881cd into microsoft:master May 25, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the upgrade!

@ctabin ctabin deleted the update-libzippp branch May 25, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants