Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsndfile] Adjust depenedncies to libsndfile #24539

Merged
merged 1 commit into from
May 5, 2022

Conversation

daschuer
Copy link
Contributor

@daschuer daschuer commented May 4, 2022

that only the really required additional external libraries are needed.

  • What does your PR fix?

This fixes link failures in the target project, because libsndfile has more dependencies by default since #23800

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

@daschuer daschuer force-pushed the libsndfile_deps branch from e37de41 to c3e8ca4 Compare May 4, 2022 20:23
…equred additional external libraries are needed
@daschuer daschuer force-pushed the libsndfile_deps branch from c3e8ca4 to d33457c Compare May 4, 2022 20:29
@BillyONeal BillyONeal merged commit 87b258e into microsoft:master May 5, 2022
@BillyONeal
Copy link
Member

Thanks for making dependencies more accurate!

@daschuer
Copy link
Contributor Author

daschuer commented May 5, 2022

Unfortunately this PR works only half way:

Installing vamp-sdk only still pulls in the default libsndfile with all dependency along with the waste of CPU time.

./vcpkg install vamp-sdk --dry-run
Computing installation plan...
The following packages will be built and installed:
  * libflac[core]:x64-linux -> 1.3.4
  * libogg[core]:x64-linux -> 1.3.5
  * libsndfile[core,external-libs,mpeg]:x64-linux -> 1.1.0
  * libvorbis[core]:x64-linux -> 1.3.7#2
  * mp3lame[core]:x64-linux -> 3.100#7
  * mpg123[core]:x64-linux -> 1.29.2#3
  * opus[core]:x64-linux -> 1.3.1#6
    vamp-sdk[core]:x64-linux -> 2.10#3
Additional packages (*) will be modified to complete this operation.

however, explicitly installing the libsndfile[core] does work:

./vcpkg install libsndfile[core] vamp-sdk --dry-run
Computing installation plan...
The following packages will be built and installed:
    libsndfile[core]:x64-linux -> 1.1.0
    vamp-sdk[core]:x64-linux -> 2.10#3

Is this an vcpkg-tool regression?

@dg0yt
Copy link
Contributor

dg0yt commented May 5, 2022

#11602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants