-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMakeRC] Add new port #24454
[CMakeRC] Add new port #24454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for cmakerc but no changes to version or port version.
-- Version: 2021-08-27
-- Old SHA: 5d87fadf9a36c2346477c4a72b1bcf7dbee2afc5
-- New SHA: 23c4f2a7faae911ecc264e6e775ad77fcc7c44cc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for cmakerc but no changes to version or port version.
-- Version: 2021-08-27
-- Old SHA: 23c4f2a7faae911ecc264e6e775ad77fcc7c44cc
-- New SHA: bcc7cc3a7d19acc6e11cb3c03e16208b750d8489
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for cmakerc but no changes to version or port version.
-- Version: 2021-08-27
-- Old SHA: 23c4f2a7faae911ecc264e6e775ad77fcc7c44cc
-- New SHA: d44e1fe27676ec334adb098ec3a3734e6b8ac0ff
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
This is not a library why package it with vcpkg? |
Actually, it is. The author just embeds C++ code into CMake: So in C++, you use it like a normal library. #include <cmrc/cmrc.hpp>
int main() {
// ...
} I'm not sure how to handle such things properly. That's why I created the PR. Looking forward to changes to be requested. Why I ever created the PR is because I want all dependencies to be managed by vcpkg without copy-pasting anything into sources. In fact, CMakeRC can be treated as a header-only library that is hidden inside a CMake script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for cmakerc but no changes to version or port version.
-- Version: 2021-08-27
-- Old SHA: d44e1fe27676ec334adb098ec3a3734e6b8ac0ff
-- New SHA: 740fd9bb83e79eba29ccd69546d2b3105d719d5d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
FTR the CMake package name doesn't need to match the port name. The config just needs to go a matching directory. However, the project calls itself "CMakeRC". OTOH the C++ functions and includes are in namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to me.
|
There's currently an outstanding issue with the CLA bot; I pushed a merge into this to get the Actions bot to confirm that the version DB edits were OK (they were as far as I could tell). Because it was entirely green before this (in 8efad51 ) I'm going to force merge this once everything else is green. |
CMakeRC - A Standalone CMake-Based C++ Resource Compiler
https://github.com/vector-of-bool/cmrc
This port contains only one CMake file.
Port is called
cmakerc
, notcmrc
cause we needfind_package(CMakeRC REQUIRED)
, notfind_package(cmrc REQUIRED)
Usage