[capstone] update to 5.0.0-rc2 #23979

theblackunknown · 2022-04-04T11:44:56Z

Describe the pull request

This PR upgrades the capstone port to 5.0.0-rc2 version.
This update allows us to simplify the portfile.cmake thanks to recent improvements.

Which triplets are supported/not supported? Have you updated the CI baseline?

They are all supported, no update was made to ci.baseline.txt

Does your PR follow the maintainer guide?

Yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-04-06T06:28:19Z

@theblackunknown ,Thanks for your pr, looks the ci tested failed on many triplets,
This is error log, Please take a look
install-x86-windows-dbg-out.log

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for triton but no changes to version or port version.
-- Version: 0.9#1
-- Old SHA: 1463df6dd74dfea7d12a8610b23009259b5c1e57
-- New SHA: c815d81ae82f2dd1d0fdcecc5e4c710297cadfe8
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

theblackunknown · 2022-04-06T22:55:47Z

@JonLiu1993 Indeed, the triton port has been impacted.
I have just pushed a series of changes which should solves this, I'll check later the CI results.

theblackunknown · 2022-04-06T22:56:38Z

Commit a15961a is irrelevant to this PR but I have noticed an error in the way the library linkage was done for triton.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 01d6f6ff1e5332b926099f0c23bda996940ad4e8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/t-/triton.json b/versions/t-/triton.json
index 990b30c..b4daf87 100644
--- a/versions/t-/triton.json
+++ b/versions/t-/triton.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "c815d81ae82f2dd1d0fdcecc5e4c710297cadfe8",
+      "git-tree": "ae7bc963fc22c2865bc3e7a5460874c06870e386",
       "version": "0.9",
       "port-version": 2
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cc2dd8fed39acc588c9a9a04b1ea4d04ce5308f0 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/t-/triton.json b/versions/t-/triton.json
index 990b30c..2bc4063 100644
--- a/versions/t-/triton.json
+++ b/versions/t-/triton.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "c815d81ae82f2dd1d0fdcecc5e4c710297cadfe8",
+      "git-tree": "220ce7aa574609f64206fc02906b1bd2eafbc8aa",
       "version": "0.9",
       "port-version": 2
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-04-07T02:31:40Z

@theblackunknown ,Fixed a lot of triplets, now only UWP is left,
install-x64-uwp-dbg-out.log

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

theblackunknown · 2022-04-07T10:52:59Z

Looks @JonLiu1993 ! It is all green !

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/capstone/vcpkg.json

Valid values for the license field can be found in the documentation

strega-nil-ms · 2022-04-08T22:32:14Z

Thanks!

* master: (139 commits) [dstorage] Add port for Microsoft.Direct3D.DirectStorage NuGet (microsoft#24063) [vcpkg] Refactor toolchain & generator selection (microsoft#23846) [icu] update to 70.1 (microsoft#23445) [vcpkg] Update android usage documentation (microsoft#23690) [LMDB] update to 0.9.29 (microsoft#24045) [catch2] Don't install docs (microsoft#24046) [harfbuff] fix arm64 osx build (microsoft#24055) [openxr-loader] remove from CI baseline (microsoft#24057) [imath] Update to 3.1.5 (microsoft#24059) [openssl] Fix dynamic builds on UNIX (microsoft#24061) [c-ares] update to 1.18.1 (microsoft#24062) [igraph] update to 0.9.8 (microsoft#24065) [cmake-user] Fix library check (microsoft#24070) [openxr-loader] fix ci.baseline.txt (microsoft#24073) [tinycbor] Fix file conflicts with libcbor (microsoft#24056) [graphviz,libslirp] Limit msys to windows (microsoft#24032) [bdwgc] Don't build docs (microsoft#24025) [capstone] update to 5.0.0-rc2 (microsoft#23979) [clockutils] Fix x64-windows-static-md (microsoft#23965) [braft] New port (microsoft#23830) ...

[capstone] update to 5.0.0 alpha

b6dc08b

github-actions bot approved these changes Apr 4, 2022

View reviewed changes

theblackunknown mentioned this pull request Apr 4, 2022

Add tool to CMake setup, improve vcpkg workflow and simple CMake Github Worklfow wolfpld/tracy#356

Closed

JonLiu1993 self-assigned this Apr 6, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 6, 2022

JonLiu1993 added the requires:author-response label Apr 6, 2022

github-actions bot requested changes Apr 6, 2022

View reviewed changes

MACHIZAUD Andréa added 2 commits April 7, 2022 00:58

[triton] upgrade to support capstone 5

acabf13

[triton] fix incorrect library linkage

a15961a

theblackunknown force-pushed the capstone-5 branch from 8c4dac2 to b6aa955 Compare April 6, 2022 22:58

github-actions bot requested changes Apr 6, 2022

View reviewed changes

[triton] bump port version

9d569ec

theblackunknown force-pushed the capstone-5 branch from b6aa955 to 9d569ec Compare April 6, 2022 23:03

github-actions bot approved these changes Apr 6, 2022

View reviewed changes

[capstone] Silence CRT Secure Function warning

4ce56f2

github-actions bot approved these changes Apr 7, 2022

View reviewed changes

[capstone] update to 5.0.0-rc2

f3f4e2c

theblackunknown changed the title ~~[capstone] update to 5.0.0 alpha~~ [capstone] update to 5.0.0-rc2 Apr 7, 2022

github-actions bot approved these changes Apr 7, 2022

View reviewed changes

JonLiu1993 approved these changes Apr 8, 2022

View reviewed changes

JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 8, 2022

strega-nil-ms merged commit 65c66cd into microsoft:master Apr 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[capstone] update to 5.0.0-rc2 #23979

[capstone] update to 5.0.0-rc2 #23979

theblackunknown commented Apr 4, 2022 •

edited

Loading

github-actions bot left a comment

JonLiu1993 commented Apr 6, 2022

github-actions bot left a comment

theblackunknown commented Apr 6, 2022

theblackunknown commented Apr 6, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Apr 7, 2022

github-actions bot left a comment

theblackunknown commented Apr 7, 2022

github-actions bot left a comment

strega-nil-ms commented Apr 8, 2022

[capstone] update to 5.0.0-rc2 #23979

[capstone] update to 5.0.0-rc2 #23979

Conversation

theblackunknown commented Apr 4, 2022 • edited Loading

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Apr 6, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

theblackunknown commented Apr 6, 2022

theblackunknown commented Apr 6, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Apr 7, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

theblackunknown commented Apr 7, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

strega-nil-ms commented Apr 8, 2022

theblackunknown commented Apr 4, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

theblackunknown commented Apr 6, 2022 •

edited

Loading