Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR Suggestions #23674

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix PR Suggestions #23674

merged 1 commit into from
Mar 21, 2022

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Mar 20, 2022 •
edited
Loading

@autoantwort autoantwort changed the title Revert "[vcpkg-ci] Update "PR Suggestions" workflow actions (#23520)" Fix PR Suggestions Mar 20, 2022
@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Mar 21, 2022
@JackBoosY
Copy link
Contributor

cc @BillyONeal

@JackBoosY JackBoosY requested a review from BillyONeal March 21, 2022 06:39
@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels Mar 21, 2022
@JackBoosY JackBoosY requested review from JackBoosY and removed request for JackBoosY March 21, 2022 06:40
@JackBoosY JackBoosY self-assigned this Mar 21, 2022
@autoantwort autoantwort marked this pull request as ready for review March 21, 2022 09:29
@xavier2k6
Copy link
Contributor

@autoantwort Thanks for the fix & apologies for the extra noise/breakage......(an oversight on my part)

@BillyONeal BillyONeal merged commit 04ec3b4 into microsoft:master Mar 21, 2022
@BillyONeal
Copy link
Member

Sorry for blindly merging the previous change, and thank you for the fixes!

@autoantwort autoantwort mentioned this pull request Mar 22, 2022
Merged
@dg0yt dg0yt mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@Cheney-W Cheney-W

@JackBoosY JackBoosY

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post PR suggestions are broken
5 participants
@autoantwort @JackBoosY @xavier2k6 @BillyONeal @Cheney-W