-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imgui] Update to 1.87 [implot] Update to 0.13 #22988
Conversation
@RT222 ,Thanks for your pr, looks ci failed on x64_osx triplet, |
I added a patch to fix this and also submitted a PR upstream : epezent/implot#322 |
I have a question about how I should update this port in the future. It's not in implot goals to support pre C++11 compiler (epezent/implot#322 (comment)), but from my understanding, it's what is used to build for osx. I am completely clueless about this platform, but patching implot continually to support it doesn't seem very realistic in the long term as the library will growth and the patch will get bigger and uglier. What is the best way to handle this? Am I mistaken and it there a way to build C++11 libraries on osx, or should we remove the support of this platform for implot? |
Nevermind, I suddenly remembered the C++ standard could simply be configured through the CMake file. 😑 (and sorry about the close, I missclicked). |
LGTM, thanks for the update! |
* master: (54 commits) [imgui] Update to 1.87 [implot] Update to 0.13 (microsoft#22988) [nu-book-zxing-cpp] New port (microsoft#22657) [librabbitmq] Update to 0.11.0 (microsoft#23037) [doc] Add doc for `supports` expression `staticcrt` (microsoft#23079) [doctest] Update to 2.4.8 (microsoft#23081) [log4cplus] Remove unneeded catch dependency (microsoft#23066) [Azure SDK] Update vcpkg ports for Feb Release (microsoft#23080) [Freerdp] Update to 2.5.0 (microsoft#23095) Update vcpkg-tool to 2022-02-11 (microsoft#23059) Minor bugfixes to MacOS deployment readme. (microsoft#23062) [ci.baseline.txt] Skip colmap on osx due to metis conflict (microsoft#23047) [gtkmm] update to 4.6.0 (microsoft#23024) [faiss] Update to 1.7.2 (microsoft#22705) [ocilib] Disable warning C4191 (microsoft#23028) [polyhook2] Update to latest (microsoft#23044) Add notice about how to export unofficial CMake targets. (microsoft#23041) [Spirv reflect] Add new port (microsoft#22295) [easyhook] Update target .NET Framework version to 4.7.2. (microsoft#23040) [gh suggestions] change license link, make it details (microsoft#22946) [field3d] Remove port (microsoft#22463) ...
Update the imgui port from 1.86 to 1.87 and the implot port from 0.12 to 0.13.
Changelogs :
https://github.com/ocornut/imgui/releases/tag/v1.87
https://github.com/epezent/implot/releases/tag/v0.13