Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq] Update version to 14.1 2 #22516

Merged
merged 14 commits into from
Mar 23, 2022
Merged

Conversation

daschuer
Copy link
Contributor

@daschuer daschuer commented Jan 13, 2022

Update to 14.1

This continues #22254

The resulting binary is not tested!

  • What does your PR fix?

just an update #15582

The issue in the original PR was that on the case insensitive file system of macOS the file INSTALL was considered as more recent that the install target. The custom Makefile fixes this.
In addition I have fixed some error messages regarding the manual-ink folder and the patches

  • Which triplets are supported/not supported? Have you updated the CI baseline?

no change

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

@JonLiu1993 JonLiu1993 changed the title Pdate libpq 14.1 2 [libpq] Update version to 14.1 2 Jan 13, 2022
@JonLiu1993 JonLiu1993 self-assigned this Jan 13, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 13, 2022
@JonLiu1993
Copy link
Member

@daschuer ,Thanks for your pr, CI test failed on x64-windows, could you please take a look:
install-x64-windows-dbg-out.log

@Neumann-A
Copy link
Contributor

The Ci error wasn't related to this PR. The error is a baseline regression and can also be found in other PRs

@JackBoosY
Copy link
Contributor

Depends on #22534

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jan 15, 2022
@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libpq/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@daschuer
Copy link
Contributor Author

The script changes are now here: #22798

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 07e508359ca5488456988191d8709722484daccd -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libpq.json b/versions/l-/libpq.json
index e59523d..5678bef 100644
--- a/versions/l-/libpq.json
+++ b/versions/l-/libpq.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "0f621deb2571997c8b8d577fc739b344cdc8f952",
+      "git-tree": "5adc85ca2060c8c5496d982a5291a601b8f82b41",
       "version": "14.1",
       "port-version": 0
     },

@daschuer
Copy link
Contributor Author

FAILED: bin/appman-dumpqmltypes.exe src/tools/dumpqmltypes/qmltypes D:/buildtrees/qtapplicationmanager/x64-windows-dbg/src/tools/dumpqmltypes/qmltypes 
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=src\tools\dumpqmltypes\CMakeFiles\appman-dumpqmltypes.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\x64\link.exe  @CMakeFiles\appman-dumpqmltypes.rsp  /out:bin\appman-dumpqmltypes.exe /implib:src\tools\dumpqmltypes\appman-dumpqmltypes.lib /pdb:bin\appman-dumpqmltypes.pdb /version:0.0 /machine:x64 /nologo    /debug /INCREMENTAL /subsystem:console   -DYNAMICBASE -NXCOMPAT  && cmd.exe /C "cd /D D:\buildtrees\qtapplicationmanager\x64-windows-dbg\src\tools\dumpqmltypes && D:\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E env "PATH=D:\buildtrees\qtapplicationmanager\x64-windows-dbg\src\tools\dumpqmltypes\\;D:\packages\qtapplicationmanager_x64-windows\debug\bin\\;D:\installed\x64-windows\bin\\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.31.31103\bin\HostX64\x64\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\VC\VCPackages\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\bin\Roslyn\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Team Tools\Performance Tools\x64\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Team Tools\Performance Tools\;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\x64\\;C:\Program Files (x86)\HTML Help Workshop\;C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\\x64\;C:\Program Files (x86)\Windows Kits\10\bin\\x64\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\\MSBuild\Current\Bin\amd64\;C:\Windows\Microsoft.NET\Framework64\v4.0.30319\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\\;C:\Program Files\PowerShell\7\;C:\Windows\system32\;C:\Windows\;C:\Windows\system32\Wbem\;C:\Windows\system32\WindowsPowerShell\v1.0\\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\x64\bin\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerExe\;D:/downloads/tools/perl/5.32.1.1/perl/bin\;D:/downloads/tools/python/python-3.10.2-x64\;D:/downloads/tools/ninja/1.10.2-windows\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.31.31103\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\VC\VCPackages;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\bin\Roslyn;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Team Tools\Performance Tools\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Team Tools\Performance Tools;C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\x64\;C:\Program Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\\x64;C:\Program Files (x86)\Windows Kits\10\bin\\x64;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\\MSBuild\Current\Bin\amd64;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\;C:\Program Files\PowerShell\7;C:\Windows\system32;C:\Windows;C:\Windows\system32\Wbem;C:\Windows\system32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\x64\bin;C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\VC\Linux\bin\ConnectionManagerExe;D:/downloads/tools/perl/5.32.1.1/perl/bin;D:/downloads/tools/python/python-3.10.2-x64;D:/downloads/tools/ninja/1.10.2-windows" D:/buildtrees/qtapplicationmanager/x64-windows-dbg/bin/appman-dumpqmltypes D:/buildtrees/qtapplicationmanager/x64-windows-dbg/src/tools/dumpqmltypes/qmltypes""
Exit code 0xc0000135

[254/255] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\x64\link.exe  src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir\appman-qmltestrunner_autogen\mocs_compilation.cpp.obj src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir\appman-qmltestrunner_resource.rc.res src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir\__\appman\appman.cpp.obj src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir\amtest.cpp.obj src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir\testrunner.cpp.obj src\tools\testrunner\CMakeFiles\appman-qmltestrunner.dir\.rcc\qrc_build-config.cpp.obj  /out:bin\appman-qmltestrunner.exe /implib:src\tools\testrunner\appman-qmltestrunner.lib /pdb:bin\appman-qmltestrunner.pdb /version:0.0 /machine:x64 /nologo    /debug /INCREMENTAL /subsystem:console   -DYNAMICBASE -NXCOMPAT  lib\Qt6AppManMaind.lib  D:\installed\x64-windows\debug\lib\Qt6QuickTestd.lib  D:\installed\x64-windows\debug\lib\Qt6Testd.lib  lib\Qt6AppManSharedMaind.lib  D:\installed\x64-windows\debug\lib\Qt6Widgetsd.lib  lib\Qt6AppManDBusd.lib  lib\Qt6AppManWindowd.lib  lib\Qt6AppManManagerd.lib  lib\Qt6AppManIntentServerd.lib  lib\Qt6AppManNotificationd.lib  D:\installed\x64-windows\debug\lib\Qt6Quickd.lib  D:\installed\x64-windows\debug\lib\Qt6OpenGLd.lib  D:\installed\x64-windows\debug\lib\Qt6QmlModelsd.lib  lib\Qt6AppManIntentClientd.lib  lib\Qt6AppManPluginInterfacesd.lib  lib\Qt6AppManCryptod.lib  advapi32.lib  crypt32.lib  lib\Qt6AppManMonitord.lib  D:\installed\x64-windows\debug\lib\Qt6Guid.lib  d3d11.lib  dxgi.lib  dxguid.lib  lib\Qt6AppManPackaged.lib  lib\Qt6AppManApplicationd.lib  lib\Qt6AppManCommond.lib  D:\installed\x64-windows\debug\lib\Qt6DBusd.lib  D:\installed\x64-windows\debug\lib\Qt6Concurrentd.lib  D:\installed\x64-windows\debug\lib\Qt6Qmld.lib  D:\installed\x64-windows\debug\lib\Qt6Networkd.lib  D:\installed\x64-windows\debug\lib\Qt6Cored.lib  mpr.lib  userenv.lib  ws2_32.lib  shell32.lib  lib\Qt6BundledStackwalkerd.lib  D:\installed\x64-windows\debug\lib\yaml.lib  D:\installed\x64-windows\debug\lib\archive.lib  user32.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
ninja: build stopped: subcommand failed.

i have no idea how to fix this.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 19, 2022

i have no idea how to fix this.

It is a baseline regression.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 21, 2022
@JonLiu1993 JonLiu1993 removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 22, 2022
@JonLiu1993 JonLiu1993 removed requires:author-response requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Mar 23, 2022
@JonLiu1993
Copy link
Member

Thanks to all who contributed!
All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Mar 23, 2022
@dan-shaw dan-shaw merged commit 440075a into microsoft:master Mar 23, 2022
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 26, 2022
* master: (103 commits)
  [lmdb] don't use msvc parameters with non-msvc compiler (microsoft#23653)
  Fix <version> of Python in vcpkgTools.xml (microsoft#23751)
  [sciter] escape quotes (microsoft#23752)
  [fuzzylite] Fix Linux build (microsoft#23658)
  [cpp-redis] Fix ‘sleep_for’ is not a member of ‘std::this_thread’ (microsoft#23762)
  [nlohmann-json] Fix usage text (microsoft#23749)
  [fontconfig] Do not create symlinks (microsoft#23735) (microsoft#23736)
  [winsparkle] Fix header file and debug path (microsoft#23739)
  [arb] Support dynamic build (microsoft#23743)
  [aws-sdk-cpp] update to 1.9.220 (microsoft#23729)
  Fix the VS2022 'unstable' queues. (microsoft#23742)
  [xmlsec] Bump to 1.2.33 (microsoft#23733)
  [unicorn] update to latest version v1.0.3 (microsoft#23745)
  [libpq] Update version to 14.1 2 (microsoft#22516)
  [libnoise] Export CMake files (microsoft#23682)
  [vcpk-ci] Trigger some test ports from vcpkg.cmake changes (microsoft#23430)
  [nlohmann-json] Add option to control implicit conversions behaviour (microsoft#22409)
  [libjuice] Update to 0.9.8 (microsoft#23153)
  [libgeotiff] Update to 1.7.1 (microsoft#23446)
  [minizip-ng] Updated minizip version and fixed windows build for previous version (microsoft#23684)
  ...
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Mar 26, 2022
* update to 14.1

* adjust patches

* add lz4 feature on !windows

* version stuff

* [skip actions] patch configure.ac and run autoreconf

* fix some stuff

* [skip actions] more details

* [libpq] Add license filed to vcpkg json

* [libpq] Adjust tcl version to 90g 90s and 90sg

* [libpq] fail early from unsupported features

* [libpq] lake xslt dependent from xml

* [libpq] Update version database

* [libpq] quote static

* [libpq] Update Version Database

Co-authored-by: Alexander Neumann <[email protected]>
@daschuer daschuer deleted the pdate_libpq_14.1_2 branch January 5, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants