-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wavpack] arm support #21790
[wavpack] arm support #21790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/wavpack/portfile.cmake
The regressions are not related to this changes. |
The Ci failure is unrelated. See: #21758 |
There also have a |
I cannot confirm the chromium-base:x64-osx failure in my repository: Do you have an idea how to solve the issues. Are there anywhere the detailed log files of the failure? |
Should not related to your changes. |
Can you try doing a merge or rebase with master to see if that clears up the failure? The merge-base here is really old. I tried to push such a merge for you but the PR was created without the "allow edits from maintainers" option checked so I can't help |
Rebased. @JackBoosY can we see the posted lines somewhere at Azure? |
@daschuer See https://dev.azure.com/vcpkg/public/_build/results?buildId=64249&view=results. |
The old issue is gone, but new have popped up:
|
Probably a regression from #21818 ? |
Should be fixed by #21925 |
(Can you merge with 'master'?) |
@daschuer ,Plesase merge with 'master'
|
Ping @strega-nil-ms for review again. |
I have just rebased the commits from our agreement here #21790 (comment) to master. This allown fixes the CI failure. |
Sorry for late, can you please merge to master? I have no permission to push to your branch. |
Why? This still merges cleanly. |
@daschuer We should make sure the pipeline test will pass with the master branch. |
I have no interest to rebase this branch over and over again when there is a failing review. @strega-nil Can you have another look? By the way: |
@daschuer Very sorry for that. |
The regression |
Thanks for the added support and for sticking with it for almost 6 months! |
This enables arm builds of the wavpack port
What does your PR fix?
Wrong CMAKE_SYSTEM_PROCESSOR on Osx and missing asm compiler definition of Linux
Which triplets are supported/not supported? Have you updated the CI baseline?
In addition linux-arm and crosscompiling for Apple silicon
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes