Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wavpack] arm support #21790

Merged
merged 6 commits into from
Apr 29, 2022
Merged

[wavpack] arm support #21790

merged 6 commits into from
Apr 29, 2022

Conversation

daschuer
Copy link
Contributor

@daschuer daschuer commented Dec 1, 2021

This enables arm builds of the wavpack port

  • What does your PR fix?

    Wrong CMAKE_SYSTEM_PROCESSOR on Osx and missing asm compiler definition of Linux

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    In addition linux-arm and crosscompiling for Apple silicon

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/wavpack/portfile.cmake

@JonLiu1993 JonLiu1993 assigned JonLiu1993 and JackBoosY and unassigned JonLiu1993 Dec 1, 2021
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 1, 2021
@JackBoosY
Copy link
Contributor

The regressions are not related to this changes.

@daschuer
Copy link
Contributor Author

daschuer commented Dec 6, 2021

The Ci failure is unrelated. See: #21758

@JackBoosY
Copy link
Contributor

There also have a chromium-base:x64-osx regression.

@daschuer
Copy link
Contributor Author

daschuer commented Dec 6, 2021

I cannot confirm the chromium-base:x64-osx failure in my repository:
https://github.com/daschuer/vcpkg/runs/4428747869?check_suite_focus=true

Do you have an idea how to solve the issues. Are there anywhere the detailed log files of the failure?
Other ideas?

@JackBoosY
Copy link
Contributor

FAILED: obj/base/base/superfasthash.o 
../../../../../../usr/bin/clang -MMD -MF obj/base/base/superfasthash.o.d -DSYSTEM_NATIVE_UTF8 -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION= -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=0 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DBASE_IMPLEMENTATION -I../src/25ce732 -Igen -fno-strict-aliasing -fstack-protector-strong -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../src/25ce732/tools/clang/crashreports -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -arch x86_64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -no-canonical-prefixes -Wall -Wextra -Wimplicit-fallthrough -Wunreachable-code -Wthread-safety -Wextra-semi -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-final-dtor-non-final-class -Wno-builtin-assume-aligned-alignment -Wno-deprecated-copy -Wno-non-c-typedef-for-linkage -Wmax-tokens -O0 -fno-omit-frame-pointer -fno-standalone-debug -gdwarf-4 -g2 -isysroot ../../../../../../Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.10.0 -ftrivial-auto-var-init=pattern -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-unknown-warning-option -Wno-unknown-pragmas -Wglobal-constructors -Wexit-time-destructors -Wshadow -Wexit-time-destructors -std=c11 -Wno-implicit-fallthrough -include obj/base/base/precompile.h-c -c ../src/25ce732/base/third_party/superfasthash/superfasthash.c -o obj/base/base/superfasthash.o
/bin/sh: ../../../../../../usr/bin/clang: No such file or directory

Should not related to your changes.

@BillyONeal
Copy link
Member

Can you try doing a merge or rebase with master to see if that clears up the failure? The merge-base here is really old. I tried to push such a merge for you but the PR was created without the "allow edits from maintainers" option checked so I can't help

@daschuer
Copy link
Contributor Author

daschuer commented Dec 7, 2021

Rebased.

@JackBoosY can we see the posted lines somewhere at Azure?

@JackBoosY
Copy link
Contributor

@daschuer See https://dev.azure.com/vcpkg/public/_build/results?buildId=64249&view=results.
Or click Details in the pipeline test area then click View more details on Azure Pipelines.

@daschuer
Copy link
Contributor Author

daschuer commented Dec 7, 2021

The old issue is gone, but new have popped up:

##[error]REGRESSION: tensorflow:x64-osx. If expected, add tensorflow:x64-osx=fail to .\scripts\ci.baseline.txt.
##[error]REGRESSION: tensorflow-cc:x64-osx. If expected, add tensorflow-cc:x64-osx=fail to .\scripts\ci.baseline.txt. 
##[error]REGRESSION: qtapplicationmanager:x64-linux. If expected, add qtapplicationmanager:x64-linux=fail to .\scripts\ci.baseline.txt.

@daschuer
Copy link
Contributor Author

daschuer commented Dec 7, 2021

/mnt/vcpkg-ci/buildtrees/qtapplicationmanager/src/ad43fc4b04-cc8e3e67d5.clean/src/common-lib/qtyaml.cpp:39:10: fatal error: yaml.h: No such file or directory

Probably a regression from #21818 ?

@BillyONeal
Copy link
Member

Should be fixed by #21925

@BillyONeal
Copy link
Member

(Can you merge with 'master'?)

@JonLiu1993
Copy link
Member

@daschuer ,Plesase merge with 'master'

remote: Permission to daschuer/vcpkg.git denied to JonLiu1993

@JackBoosY
Copy link
Contributor

Ping @strega-nil-ms for review again.

@daschuer
Copy link
Contributor Author

daschuer commented Feb 7, 2022

I have just rebased the commits from our agreement here #21790 (comment) to master. This allown fixes the CI failure.

@JackBoosY
Copy link
Contributor

Sorry for late, can you please merge to master? I have no permission to push to your branch.

@daschuer
Copy link
Contributor Author

Why? This still merges cleanly.

@JackBoosY
Copy link
Contributor

JackBoosY commented Mar 18, 2022

@daschuer We should make sure the pipeline test will pass with the master branch.
And the test results may be out-dated since other relate port was changed.

@daschuer
Copy link
Contributor Author

I have no interest to rebase this branch over and over again when there is a failing review.

@strega-nil Can you have another look?

By the way:
The maintainer edits checkbox is checked.

@JackBoosY
Copy link
Contributor

@daschuer Very sorry for that.

@JackBoosY
Copy link
Contributor

The regression libmikmod:x64-osx is a baseline issue and will be fixed by other PR.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Mar 21, 2022
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 28, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 29, 2022
@BillyONeal BillyONeal merged commit 8ca9b2b into microsoft:master Apr 29, 2022
@BillyONeal
Copy link
Member

Thanks for the added support and for sticking with it for almost 6 months!

@daschuer daschuer deleted the wavpack_arm branch January 5, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants