[scripts-audit] Make buildsystem

[JackBoosY]

Audit the Makefile build system according to the documentation.

Related: #17691

• Depends on PR [scripts-audit] vcpkg_fixup_pkgconfig #19658

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

@BillyONeal Can you investigate on the crash issue?

Building package icu[core]:x64-windows-static-md...
Error: vcpkg has crashed; no additional details are available.

https://dev.azure.com/vcpkg/public/_build/results?buildId=59690&view=logs&j=36cc18b5-b00b-5122-dfd2-906b0f3945db&t=a2fc3f1b-543d-5cac-7a17-d6646137a2ea

Thanks.

[JackBoosY]

Crashed in this line -> https://github.com/microsoft/vcpkg-tool/blob/main/src/vcpkg/build.cpp#L1238:

 Checks::check_exit(VCPKG_LINE_INFO, status_it != status_db.end());

The pipeline log shows:

2021-09-16T09:56:13.3841766Z Starting package 180/622: icu:x64-windows
2021-09-16T09:56:13.3849146Z Building package icu[core]:x64-windows...
...
2021-09-16T09:57:43.6733894Z -- Building x64-windows-dbg
2021-09-16T09:57:43.6741382Z CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
2021-09-16T09:57:43.6748794Z     Command failed: D:/downloads/tools/msys2/8a1f6fda6ae3aa5c/usr/bin/make.exe -j 33 --trace -f Makefile all
2021-09-16T09:57:43.6756061Z     Working Directory: D:/buildtrees/icu/x64-windows-dbg
2021-09-16T09:57:43.6763636Z     See logs for more information:
2021-09-16T09:57:43.6771269Z       D:\buildtrees\icu\build-x64-windows-dbg-out.log
2021-09-16T09:57:43.6778924Z       D:\buildtrees\icu\build-x64-windows-dbg-err.log
2021-09-16T09:57:43.6781989Z 
2021-09-16T09:57:43.6789692Z Call Stack (most recent call first):
2021-09-16T09:57:43.6799368Z   scripts/cmake/vcpkg_build_make.cmake:198 (vcpkg_execute_build_process)
2021-09-16T09:57:43.6806698Z   scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
2021-09-16T09:57:43.6813904Z   ports/icu/portfile.cmake:124 (vcpkg_install_make)
2021-09-16T09:57:43.6821118Z   scripts/ports.cmake:140 (include)
2021-09-16T09:57:43.6823851Z 
2021-09-16T09:57:43.6826742Z 
2021-09-16T09:57:43.6834235Z Error: Building package icu:x64-windows failed with: BUILD_FAILED
2021-09-16T09:57:43.6841328Z Elapsed time for package icu:x64-windows: 1.506 min
2021-09-16T09:57:43.6848387Z Starting package 181/622: icu:x86-windows
2021-09-16T09:57:43.6855752Z Building package icu[core]:x86-windows...
2021-09-16T09:57:43.6862931Z Error: vcpkg has crashed; no additional details are available.
2021-09-16T09:57:43.6870127Z The source line is D:\a\_work\1\s\src\vcpkg\build.cpp(1238)

Even if --keep-going was added, since icu is a host port, icu[core]:x86-windows requires icu[core]:x64-windows. So what is expected is to stop building icu[core]:x86-windows after the build of icu[core]:x64-windows fails. But it doesn't.

Confirmed, I can use this branch and command ./vcpkg install icu[core]:x86-windows --keepgoing to reproduce this issue,

[dg0yt]

I just noticed that you have another open PR with the same title: #19753.

[BillyONeal]

Crashed in this line -> https://github.com/microsoft/vcpkg-tool/blob/main/src/vcpkg/build.cpp#L1238:

 Checks::check_exit(VCPKG_LINE_INFO, status_it != status_db.end());

The pipeline log shows:

2021-09-16T09:56:13.3841766Z Starting package 180/622: icu:x64-windows
2021-09-16T09:56:13.3849146Z Building package icu[core]:x64-windows...
...
2021-09-16T09:57:43.6733894Z -- Building x64-windows-dbg
2021-09-16T09:57:43.6741382Z CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
2021-09-16T09:57:43.6748794Z     Command failed: D:/downloads/tools/msys2/8a1f6fda6ae3aa5c/usr/bin/make.exe -j 33 --trace -f Makefile all
2021-09-16T09:57:43.6756061Z     Working Directory: D:/buildtrees/icu/x64-windows-dbg
2021-09-16T09:57:43.6763636Z     See logs for more information:
2021-09-16T09:57:43.6771269Z       D:\buildtrees\icu\build-x64-windows-dbg-out.log
2021-09-16T09:57:43.6778924Z       D:\buildtrees\icu\build-x64-windows-dbg-err.log
2021-09-16T09:57:43.6781989Z 
2021-09-16T09:57:43.6789692Z Call Stack (most recent call first):
2021-09-16T09:57:43.6799368Z   scripts/cmake/vcpkg_build_make.cmake:198 (vcpkg_execute_build_process)
2021-09-16T09:57:43.6806698Z   scripts/cmake/vcpkg_install_make.cmake:26 (vcpkg_build_make)
2021-09-16T09:57:43.6813904Z   ports/icu/portfile.cmake:124 (vcpkg_install_make)
2021-09-16T09:57:43.6821118Z   scripts/ports.cmake:140 (include)
2021-09-16T09:57:43.6823851Z 
2021-09-16T09:57:43.6826742Z 
2021-09-16T09:57:43.6834235Z Error: Building package icu:x64-windows failed with: BUILD_FAILED
2021-09-16T09:57:43.6841328Z Elapsed time for package icu:x64-windows: 1.506 min
2021-09-16T09:57:43.6848387Z Starting package 181/622: icu:x86-windows
2021-09-16T09:57:43.6855752Z Building package icu[core]:x86-windows...
2021-09-16T09:57:43.6862931Z Error: vcpkg has crashed; no additional details are available.
2021-09-16T09:57:43.6870127Z The source line is D:\a\_work\1\s\src\vcpkg\build.cpp(1238)

Even if --keep-going was added, since icu is a host port, icu[core]:x86-windows requires icu[core]:x64-windows. So what is expected is to stop building icu[core]:x86-windows after the build of icu[core]:x64-windows fails. But it doesn't.

Confirmed, I can use this branch and command ./vcpkg install icu[core]:x86-windows --keepgoing to reproduce this issue,

This happens whenever a port depends on a host-port, and the host-port build failed.

[strega-nil-ms]

Hopefully you get some good things to look at so that you can continue making these changes.

[JackBoosY]

@strega-nil-ms Do you have any suggestions?

[strega-nil]

@JackBoosY this is all that I see that needs to be done, thanks!

[JackBoosY]

@strega-nil-ms Ready for merge 🚀

[strega-nil-ms]

Merge as soon as green! :)

[JackBoosY]

@strega-nil-ms All green now! 🤖

[strega-nil-ms]

Thank you so much @JackBoosY for this <3

[gerard-ryan-immersaview]

This PR introduces some undocumented changes.
VCPKG_MAKE_CONFIGURE_OPTIONS -> VCPKG_CONFIGURE_MAKE_OPTIONS

Relevent Triplet Files documentation

[KUGA2]

This PR introduces some undocumented changes. VCPKG_MAKE_CONFIGURE_OPTIONS -> VCPKG_CONFIGURE_MAKE_OPTIONS

Relevent Triplet Files documentation

I just added an issue there.