[openjpeg] Update version to 2.4.0 #20021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
info:internal
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NancyLi1013
approved these changes
Sep 8, 2021
|
What happened to the tools that are no longer associated with some of the features? Where they removed by upstream? |
NancyLi1013
added
requires:author-response
and removed
info:reviewed
|
I have tested the old version of this port, those removed tools have never been successfully generated since they were added to vcpkg, I will investigate in detail why they are not generated, but the focus will probably be on the jpip feature, as the other 3 have been removed on upstream. |
dg0yt
reviewed
Sep 24, 2021
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [openjpeg] update to 2.4.0 #19968
Features test:
x86-windows
x64-windows
x64-windows-static
This issue is a known issue opj 2.4.0: opj_free missing in opj3d uclouvain/openjpeg#1327 and it has been fixed by upstream's PR Remove obsolete components JPWL, JP3D and MJ2 uclouvain/openjpeg#1350 .
Because our current update does not include this PR, we are keeping these features instead of removing them.