Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libimobiledevice/libideviceactivation] update to latest version #19962

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Sep 3, 2021

Fix #19930 #19929

Update libimobiledevice、libideviceactivation to the latest version

Note: no feature need to test

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Sep 3, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/libzen/vcpkg.json b/ports/libzen/vcpkg.json
index 82129ec..2a088fe 100644
--- a/ports/libzen/vcpkg.json
+++ b/ports/libzen/vcpkg.json
@@ -5,11 +5,11 @@
   "dependencies": [
     {
       "name": "vcpkg-cmake",
-      "host": true      
+      "host": true
     },
     {
       "name": "vcpkg-cmake-config",
-      "host": true      
-    }    
+      "host": true
+    }
   ]
 }
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5835ade57b8ca9fbdf23e1da9857fc039c443310 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libzen.json b/versions/l-/libzen.json
index 5918b7d..2ec7d71 100644
--- a/versions/l-/libzen.json
+++ b/versions/l-/libzen.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "f8032150101fe2169a64cafe88a9daaf8f3961e7",
+      "git-tree": "92da085623839403d020b38849618ac951dc0308",
       "version-semver": "0.4.39",
       "port-version": 0
     },

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libideviceactivation/portfile.cmake
  • ports/libimobiledevice/portfile.cmake
  • ports/libproxy/portfile.cmake
  • ports/libzen/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/ffnvcodec/portfile.cmake
  • ports/libideviceactivation/portfile.cmake
  • ports/libimobiledevice/portfile.cmake
  • ports/libproxy/portfile.cmake

@JonLiu1993 JonLiu1993 changed the title [libimobiledevice/libideviceactivation/libzen] update to latest version [libimobiledevice/libideviceactivation] update to latest version Sep 17, 2021
@JonLiu1993 JonLiu1993 marked this pull request as ready for review September 17, 2021 11:03
ports/libideviceactivation/vcpkg.json Outdated Show resolved Hide resolved
ports/libimobiledevice/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member Author

Depends on pr #20236

…Jon/libimobiledevice-libideviceactivation-libzen
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 23, 2021
@BillyONeal BillyONeal merged commit 50fcd63 into microsoft:master Sep 24, 2021
@BillyONeal
Copy link
Member

Thanks for the version updates!

@JonLiu1993 JonLiu1993 deleted the dev/Jon/libimobiledevice-libideviceactivation-libzen branch September 24, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libimobiledevice] update to 1.3.17 [libideviceactivation] update to 1.3.17
3 participants