-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts-audit] vcpkg_fixup_pkgconfig #19348
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @Neumann-A for review this PR. |
JackBoosY
added
category:scripts-audit
Part of the scripts audit effort.
category:tool-update
The issue is with build tool or build script, which requires update or should be executed correctly
info:internal
This PR or Issue was filed by the vcpkg team.
labels
Aug 4, 2021
Neumann-A
reviewed
Aug 4, 2021
Neumann-A
reviewed
Aug 4, 2021
strega-nil-ms
added
info:next-rollup
and removed
category:tool-update
The issue is with build tool or build script, which requires update or should be executed correctly
labels
Aug 4, 2021
strega-nil-ms
force-pushed
the
vcpkg_fixup_pkgconfig
branch
from
August 5, 2021 18:25
17ea086
to
8d1c5d8
Compare
51 tasks
strega-nil-ms
force-pushed
the
vcpkg_fixup_pkgconfig
branch
from
August 9, 2021 17:44
8d1c5d8
to
e0ee0c7
Compare
Closed for rollup #19469. |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Aug 11, 2021
[scripts-audit] vcpkg_fixup_pkgconfig
strega-nil-ms
added a commit
that referenced
this pull request
Aug 16, 2021
* [rollup:2021-08-09] PR #16706 (@JackBoosY) [vcpkg_fixup_cmake_targets] Fix up OSX system development path * [rollup:2021-08-09] PR #19238 (@strega-nil) [scripts-audit] vcpkg_download_distfile * [rollup:2021-08-09] PR #19239 (@strega-nil) [scripts-audit] vcpkg_find_fortran * [rollup:2021-08-09] PR #19338 (@strega-nil) [tinyfiledialogs] Fix for good * [rollup:2021-08-09] PR #19348 (@strega-nil) [scripts-audit] vcpkg_fixup_pkgconfig * fix ports.cmake with newer vcpkg_download_distfile * fix vcpkg create * move vcpkg_common_definitions down so that it's not incorrect * fix vcpkg_internal_get_cmake_vars Co-authored-by: nicole mazzuca <[email protected]> Co-authored-by: Jack·Boos·Yu <[email protected]> Co-authored-by: Billy Robert O'Neal III <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:scripts-audit
Part of the scripts audit effort.
info:internal
This PR or Issue was filed by the vcpkg team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on abseil - no changes except for ordering.