Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts-audit] vcpkg_fixup_pkgconfig #19348

Closed
wants to merge 2 commits into from

Conversation

strega-nil
Copy link
Contributor

Tested on abseil - no changes except for ordering.

@JackBoosY
Copy link
Contributor

cc @Neumann-A for review this PR.

@JackBoosY JackBoosY added category:scripts-audit Part of the scripts audit effort. category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team. labels Aug 4, 2021
@strega-nil-ms strega-nil-ms added info:next-rollup and removed category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Aug 4, 2021
@strega-nil-ms strega-nil-ms force-pushed the vcpkg_fixup_pkgconfig branch from 17ea086 to 8d1c5d8 Compare August 5, 2021 18:25
@strega-nil-ms strega-nil-ms force-pushed the vcpkg_fixup_pkgconfig branch from 8d1c5d8 to e0ee0c7 Compare August 9, 2021 17:44
@strega-nil-ms
Copy link
Contributor

Closed for rollup #19469.

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Aug 11, 2021
[scripts-audit] vcpkg_fixup_pkgconfig
strega-nil-ms added a commit that referenced this pull request Aug 16, 2021
* [rollup:2021-08-09] PR #16706 (@JackBoosY)

[vcpkg_fixup_cmake_targets] Fix up OSX system development path

* [rollup:2021-08-09] PR #19238 (@strega-nil)

[scripts-audit] vcpkg_download_distfile

* [rollup:2021-08-09] PR #19239 (@strega-nil)

[scripts-audit] vcpkg_find_fortran

* [rollup:2021-08-09] PR #19338 (@strega-nil)

[tinyfiledialogs] Fix for good

* [rollup:2021-08-09] PR #19348 (@strega-nil)

[scripts-audit] vcpkg_fixup_pkgconfig

* fix ports.cmake with newer vcpkg_download_distfile

* fix vcpkg create

* move vcpkg_common_definitions down so that it's not incorrect

* fix vcpkg_internal_get_cmake_vars

Co-authored-by: nicole mazzuca <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
Co-authored-by: Billy Robert O'Neal III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:scripts-audit Part of the scripts audit effort. info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants