[tiff] Update to 4.3.0, improvements

[dg0yt]

• What does your PR fix?

  • Updates tiff to 4.3.0. Fixes [tiff] update to 4.3.0 #18011.
  • Revised feature interface. C++ lib tiffcxx is opt-in now. Former "tool" is "tools" now.
  • Fixes pc and cmake config files. Fixes [tiff] Installed pkg-config (.pc) debug files specify non-existent includedir #14849.
  • Migrate to vcpkg-cmake ports

• Important change in libtiff 4.3.0

  Use of "int8", "uint8", "int16", "uint16", "int32", "uint32", "int64", "uint64" typedefs is now deprecated. libtiff code and headers no longer use them, and use their C99 standard equivalents (with "_t" suffix). Those typedefs are still available, with deprecation warnings, but external code is strongly encouraged to use the corresponding C99 stdint.h types. The deprecated types might be removed in a future release.

  (From https://libtiff.gitlab.io/libtiff/v4.3.0.html#libtiff)
  This affects at least port selene which treated these warnings as errors.

• Which triplets are supported/not supported? Have you updated the CI baseline?

  all, no

• Does your PR follow the maintainer guide?

  yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  I am still working on this PR.

[dg0yt]

Manually tested, covering the cmake wrapper:
tiff[cxx,jpeg,lzma,tools,webp,zip,zstd]:x64-linux + libgeotiff:x64-linux

[JonLiu1993]

All features are tested successfully in the following triplets:

• x86-windows
• x64-windows
• x64-windows-static
• x64-linux

[ras0219-msft]

LGTM, thanks for the update!

[strega-nil-ms]

LGTM, thanks @dg0yt :)

[AbdulAbCellera]

Hi, I have a question about CXX feature support on arm.

I want to compile with the CXX feature for Apple M1 (arm64). So I did the following:

• I removed "supports" : !arm
• I added the cxx feature to vcpkg.json
• I linked my targets to TIFF::CXX
• I compiled

These changes do not seem to have any issues.

The question is what is the best approach to get this support natively?
Do I have to link to another target?
or post a PR for arm64 support of CXX feature?

[dg0yt]

I guess this particular arm restriction is obsolete. The next PR can remove the supports line from this feature. In the mean time you may also install tiff[cxx] with --allow-unsupported.

[AbdulAbCellera]

Is there a way to set --allow-unsupported in manifest mode?

[dg0yt]

Is there a way to set --allow-unsupported in manifest mode?

Yes, just pass is through with CMAKE_INSTALL_OPTIONSVCPKG_INSTALL_OPTIONS :
https://github.com/microsoft/vcpkg/blob/master/docs/users/buildsystems/cmake-integration.md#vcpkg_install_options

[AbdulAbCellera]

I think you meant VCPKG_INSTALL_OPTIONS instead of CMAKE_INSTALL_OPTIONS :)