-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libxml2] Improve pc file #17747
[libxml2] Improve pc file #17747
Conversation
Probably there is also a dependency on CMAKE_DL_LIBS, given that HAVE_DLOPEN is defined for linux and osx. Not sure if this desired for static builds at all. |
x64_windows_static_md: paraview: |
Thanks for reviewing. After submitting the PR, I started wondering whether this usage of |
Confirmed. I will update the PR unless someone objects. |
Done: |
#17945 will also solve the pc file problem. If that PR is ready for merge soon, this PR becomes obsolete. |
I prefer to merge this PR first because my PR needs to update cmake to the latest. |
What does your PR fix?
The pc file did not list any extra libraries needed for static linking. This PR adds them, e.g. for x64-linux-dbg:
Libs.private: -pthread -lm -L/vcpkg/installed/x64-linux/debug/lib/pkgconfig/../../lib -llzmad -pthread -lz
This
helps withfixes the libxml2 test in gdalconfigure
.In addition, the PR also shortcuts a copying step introduced in my previous PR.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no.
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes
Remarks
x_vcpkg_pkgconfig_get_modules
, in order to easily to resolve recursively and with debug postfixes as needed. CC @Neumann-A