-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[glslang] Provide glslang-default-resource-limits library. #15624
Conversation
Co-authored-by: NancyLi1013 <[email protected]>
LGTM now, thanks for your PR @wolfpld. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I am not sure how relevant this is, but since this PR relates to error LNK2001: unresolved external symbol "struct TBuiltInResource const glslang::DefaultTBuiltInResource" (?DefaultTBuiltInResource@glslang@@3UTBuiltInResource@@B)
....exe : fatal error LNK1120: 1 unresolved externals If I pull the actual repository I can add this library and link the target correctly, but I am not sure if this package cmake config links the target and build it correctly as Edit: Could this PR have regressed it? #15719 |
Describe the pull request
This PR makes the glslang-default-resource-limits library publicly available for linking. This is required by third party tools using glslang, in order to get the required resource limits data structure. This struct is internally used by the glslang library and its ABI does change between releases, so it's not possible to maintain this data consistently on the third party side.
No change here, in comparison to what was previously available.
Yes, with the exception of bumping the
version
field, instead of increasing theport-version
, as this was the convention used previously in this port.