Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glslang] Provide glslang-default-resource-limits library. #15624

Merged
merged 4 commits into from
Jan 17, 2021
Merged

[glslang] Provide glslang-default-resource-limits library. #15624

merged 4 commits into from
Jan 17, 2021

Conversation

wolfpld
Copy link
Contributor

@wolfpld wolfpld commented Jan 13, 2021

Describe the pull request

  • What does your PR fix?

This PR makes the glslang-default-resource-limits library publicly available for linking. This is required by third party tools using glslang, in order to get the required resource limits data structure. This struct is internally used by the glslang library and its ABI does change between releases, so it's not possible to maintain this data consistently on the third party side.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No change here, in comparison to what was previously available.

Yes, with the exception of bumping the version field, instead of increasing the port-version, as this was the convention used previously in this port.

@ghost
Copy link

ghost commented Jan 13, 2021

CLA assistant check
All CLA requirements met.

@wolfpld wolfpld marked this pull request as ready for review January 13, 2021 13:39
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 14, 2021
ports/glslang/CONTROL Outdated Show resolved Hide resolved
ports/glslang/CMakeLists-targets.patch Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 15, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @wolfpld.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dan-shaw dan-shaw merged commit ffd5ca7 into microsoft:master Jan 17, 2021
@hiradyazdan
Copy link

hiradyazdan commented Jul 27, 2021

I am not sure how relevant this is, but since this PR relates to glslang-default-resource-limits I was wondering it should have resovled linking the target correctly, but I'm getting this error:

error LNK2001: unresolved external symbol "struct TBuiltInResource const glslang::DefaultTBuiltInResource" (?DefaultTBuiltInResource@glslang@@3UTBuiltInResource@@B)
....exe : fatal error LNK1120: 1 unresolved externals

If I pull the actual repository I can add this library and link the target correctly, but I am not sure if this package cmake config links the target and build it correctly as DefaultTBuiltInResource is declared in StandAlone/ResourceLimits.h, which seems to be missing from the vcpkg port.

Edit: Could this PR have regressed it? #15719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants