Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix single configuration make builds. #14580

Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix single configuration make builds. #14580

merged 1 commit into from
Nov 17, 2020

Conversation

Neumann-A
Copy link
Contributor

replaces #14575

@Neumann-A Neumann-A mentioned this pull request Nov 15, 2020
Closed
@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Nov 16, 2020
@JackBoosY
Copy link
Contributor

Needs rerun after #14579 merged.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 16, 2020
@Neumann-A
Copy link
Contributor Author

@JackBoosY: You can rerun it but looking into the CI logs it looks like CI is not testing anything. Everything is just extracted from the binary cache.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 17, 2020
@strega-nil strega-nil merged commit 79d9a15 into microsoft:master Nov 17, 2020
@Neumann-A Neumann-A deleted the fix_single_config_make_builds branch November 18, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neumann-A @JackBoosY @strega-nil