[libprotobuf-mutator] Add new port #13691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebdron
force-pushed
the
port/libprotobuf-mutator
branch
from
0765f67 to
0c38ed6
Compare
lebdron
force-pushed
the
port/libprotobuf-mutator
branch
from
0c38ed6 to
1662a79
Compare
NancyLi1013
added
the
category:new-port
NancyLi1013
suggested changes
Sep 24, 2020
|
Hi @lebdron |
lebdron
force-pushed
the
port/libprotobuf-mutator
branch
2 times, most recently
from
0d1db0d to
9351c74
Compare
NancyLi1013
reviewed
Nov 2, 2020
lebdron
force-pushed
the
port/libprotobuf-mutator
branch
from
9351c74 to
d5db90b
Compare
NancyLi1013
approved these changes
Nov 13, 2020
|
LGTM, only one thing needs to be confirmed now. I noticed that there are no any released version for the new port. So is it possible to release a stable version for |
|
I am afraid I have to ping @vitalybuka again as I cannot make a release, and also google/libprotobuf-mutator#186 is a relevant issue. |
lebdron
force-pushed
the
port/libprotobuf-mutator
branch
2 times, most recently
from
a40b50e to
1f0f362
Compare
Signed-off-by: Andrei Lebedev <[email protected]>
lebdron
force-pushed
the
port/libprotobuf-mutator
branch
from
1f0f362 to
69deac3
Compare
|
Hello @NancyLi1013 . Everything is done 😊 . Libarchive should be fixed in #14571 |
|
Thanks for your so quick response @lebdron. I will rerun this PR once PR #14571 merged. Besides this , everything seems good now. Also thanks for your help and support @vitalybuka. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Add https://github.com/google/libprotobuf-mutator port.
Which triplets are supported/not supported? Have you updated the CI baseline?
Tested
x64-linuxandx64-windows-static. Does not have dll exports, therefore no support for "windows & dynamic".Does your PR follow the maintainer guide?
Yes.