-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meson|scripts] update scripts #12945
Conversation
seems like a merged the wrong branch here once. The expat changes shouldn't be in here. |
Current error:
waiting for upstream comment |
use native/cross files make arm builds work.
9bf9f68
to
0aac8c8
Compare
something is strange here:
for me the cmd line looks virtually the same except that instead of only |
@Neumann-A Trying... |
Same error on osx machine by manually run that command:
@strega-nil Can you please take a look? |
- rename internal functions to be prefixed with _vcpkg_ - fix VCPKG_CHAINLOAD_TOOLCHAIN_FILE for ios/freebsd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see these changes made then I'll merge, thanks @Neumann-A :)
message(FATAL_ERROR "Unsupported host architecture ${BUILD_ARCH}!" ) | ||
endif() | ||
else() # TODO: add correct detection for OSX and Linux. Currently only x64 triplets are available in official vcpkg. | ||
set(BUILD_CPU_FAM x86_x64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: I have to fix this soon yay
Thanks so much @Neumann-A ! You've put a ton of work into making this a better experience and we really appreciate it 😄 |
Just for the records: |
@c72578 yeah I had to restore to using some fixed commit of meson/master since meson seems to be horribly unstable and I did not want to wait for 0.61 for this to be merged .... I also considered to somehow add patches to |
use native/cross files for meson and make crossbuilds on windows work
depends