Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lapack-reference] fix cblas feature #12929

Merged
merged 4 commits into from
Aug 26, 2020

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Aug 16, 2020

closes #12911

depends #12895 for CI success

@LilyWangL LilyWangL added the category:port-bug The issue is with a library, which is something the port should already support label Aug 17, 2020
@LilyWangL
Copy link
Contributor

@Neumann-A Thanks for your PR. I installed lapack-reference[cblas] and got the following error:

Building package lapack-reference[blas-select,cblas,core,noblas]:x64-windows... done
Installing package lapack-reference[blas-select,cblas,core,noblas]:x64-windows...
The following files are already installed in E:/Lily/pr/vcpkg/installed/x64-windows and are in conflict with lapack-reference:x64-windows

Installed by openblas:x64-windows
    include/cblas.h

@Neumann-A
Copy link
Contributor Author

@LilyWangL: noblas and cblas are by design incompatible. Still if openblas is installed there will be a file conflict between those two ports if lapack-reference is built with feature cblas.

@LilyWangL
Copy link
Contributor

Yes, if noblas and cblas are by design incompatible, blas-select should not be default feature. If blas-select is default feature, when I install lapack-reference[cblas], it will install lapack-reference[blas-select,cblas,core,noblas]. lapack-reference[cblas] will build failed on Windows.

@Neumann-A
Copy link
Contributor Author

blas-select needs to be the default feature otherwise ci and users don't get what they expect. People who explicitly want cblas must deactivate the defaults by explicitly declaring [core,cblas]. Feature cblas only exists for corner cases and should be treated as such.

@Neumann-A
Copy link
Contributor Author

The feature is also up for removal as soon as a native windows fortran compiler is available

@LilyWangL
Copy link
Contributor

Could add message for feature cblas to declare that this feature does not support windows temporarily?

@Neumann-A
Copy link
Contributor Author

Could add message for feature cblas to declare that this feature does not support windows temporarily?

It should support windows if you install it without the feature noblas

@LilyWangL
Copy link
Contributor

I test lapack-reference[cblas]:x64-windows-static and it can install successfully.

Building package lapack-reference[blas-select,cblas,core]:x64-windows-static... done
Installing package lapack-reference[blas-select,cblas,core]:x64-windows-static...
Installing package lapack-reference[blas-select,cblas,core]:x64-windows-static... done
Elapsed time for package lapack-reference:x64-windows-static: 6.92 min

Total elapsed time: 10.11 min

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 25, 2020
@BillyONeal BillyONeal merged commit 4a9b658 into microsoft:master Aug 26, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lapack] build failure - pkgconfig undefined prefix variable
3 participants