-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lapack-reference] fix cblas feature #12929
Conversation
@Neumann-A Thanks for your PR. I installed
|
@LilyWangL: noblas and cblas are by design incompatible. Still if openblas is installed there will be a file conflict between those two ports if lapack-reference is built with feature cblas. |
Yes, if noblas and cblas are by design incompatible, blas-select should not be default feature. If blas-select is default feature, when I install |
blas-select needs to be the default feature otherwise ci and users don't get what they expect. People who explicitly want cblas must deactivate the defaults by explicitly declaring [core,cblas]. Feature cblas only exists for corner cases and should be treated as such. |
The feature is also up for removal as soon as a native windows fortran compiler is available |
Could add message for feature cblas to declare that this feature does not support windows temporarily? |
It should support windows if you install it without the feature |
I test
|
Thanks for your contribution! |
closes #12911
depends #12895 for CI success