Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[behaviortree-cpp] Add new port #12769

Merged
merged 11 commits into from
Aug 21, 2020
Merged

[behaviortree-cpp] Add new port #12769

merged 11 commits into from
Aug 21, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Aug 5, 2020

Add new port of behaviortree-cpp: https://www.behaviortree.dev/

@seanyen seanyen force-pushed the seanyen/behaviortree.cpp branch from 25ef9b0 to 714f644 Compare August 5, 2020 22:45
@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 6, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Aug 6, 2020
@LilyWangL
Copy link
Contributor

The change of lzokay is duplicate with PR #12766.

@seanyen seanyen force-pushed the seanyen/behaviortree.cpp branch from c7be114 to 16b1f7e Compare August 6, 2020 20:58
@seanyen
Copy link
Contributor Author

seanyen commented Aug 6, 2020

Rebased.

strega-nil
strega-nil approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change, but this looks great 😄

ports/behaviortree-cpp/vcpkg.json Outdated Show resolved Hide resolved
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
seanyen and others added 2 commits August 7, 2020 11:49
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 11, 2020
@LilyWangL
Copy link
Contributor

@seanyen Now this port build failed with the following error:
D:\buildtrees\behaviortree-cpp\src\haviorTree-95072d0cc8.clean\src\action_node.cpp(72): fatal error C1083: Cannot open include file: 'boost/coroutine2/all.hpp': No such file or directory
It looks like need add dependency boost-coroutine2. Could you continue to fix it?

@seanyen
Copy link
Contributor Author

seanyen commented Aug 11, 2020

@LilyWangL Added. Let's see how it goes.

@LilyWangL
Copy link
Contributor

The CI fails is not related with this PR, it will be fixed by PR #12856.

@LilyWangL LilyWangL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 12, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@seanyen
Copy link
Contributor Author

seanyen commented Aug 17, 2020

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12769 in repo microsoft/vcpkg

@seanyen seanyen closed this Aug 17, 2020
@seanyen seanyen reopened this Aug 17, 2020
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Aug 18, 2020
BillyONeal
BillyONeal reviewed Aug 20, 2020
View reviewed changes
scripts/ci.baseline.txt Outdated
@@ -112,6 +112,7 @@ bde:x64-uwp=fail
bde:x64-windows=fail
bde:x64-windows-static=fail
bde:x86-windows=fail
behaviortree-cpp:x64-osx=fail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the port doesn't support osx perhaps it should be excluded in "Supports"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think the supports should be changed to !uwp&!osx and this item be removed from the baseline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal I updated the "Supports" part. Let's see how the CI goes. :)

@BillyONeal BillyONeal merged commit 1999412 into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
@seanyen @strega-nil @remz1337
[behaviortree-cpp] Add new port (microsoft#12769)
0d3bbd6 
Co-authored-by: nicole mazzuca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@traversaro traversaro traversaro left review comments

@BillyONeal BillyONeal BillyONeal left review comments

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanyen @LilyWangL @strega-nil @BillyONeal @traversaro