[vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix #9955 #12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicroms
approved these changes
Jul 2, 2020
E452003
added a commit
to E452003/vcpkg
that referenced
this pull request
Jul 6, 2020
* 'master' of https://github.com/microsoft/vcpkg: (1418 commits) [vcpkg integrate] Clean up vcpkg.target file (microsoft#4608) [vcpkg_from_sourceforge] Add retry mirror function (2/2) (microsoft#12018) [pcre2] Restore the https://ftp.pcre.org/ mirror in addition to the SourceForge mirrors. (microsoft#12233) [xercesc] rename feature from xmlch_wchar to xmlch-wchar (microsoft#12205) [safeint] Update to 3.24 (microsoft#12217) [vcpkg] Remove the tombstones and 'ignore' baseline concepts. (microsoft#12197) [msbuild] Revert the importance to Normal (microsoft#12212) [vtk] Added opengl feature. (microsoft#11399) [span-lite] Update to 0.7.0 (microsoft#12206) [cmocka libarchive libiconv libpq libxml2 plibsys] fix drive-by error in vcpkg-cmake-wrappers (microsoft#12196) [azure-iot-sdk-c] Fix feature name and enable to build (microsoft#12209) [vcpkg] Improve performance of compiler tracking by suppressing aspects of CMake's compiler detection. (microsoft#12203) [vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix microsoft#9955 (microsoft#12201) [sqlite3] update to 3.32.3 to deal with security issues (microsoft#12185) [infoware] Bump version to 0.5.4 (microsoft#12167) [imgui] Update to 1.77 (microsoft#12155) [vcpkg] Update message in bootstrap.ps1 (microsoft#12145) [vcpkg] Enable NuGet-based binary caching via mono (microsoft#12170) Don't change manifest root when manifest isn't enabled. (microsoft#12191) Fix sourceparagraph:BooleanField (microsoft#12192) ...
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…osoft#9955 (microsoft#12201) Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9955, however it does not introduce a way to ensure this is maintainable long term.
Tested using docker with
centos:7:yum install centos-release-scl yum install devtoolset-8 scl enable devtoolset-8 bash ./bootstrap-vcpkg.shWhat does your PR fix? Fixes bootstrap failed to build on Centos (devtoolset-7, 8) #9955
Which triplets are supported/not supported? Have you updated the CI baseline?
N/A
Does your PR follow the maintainer guide?
Yes