Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add keyword Supports to Feature in CONTROL file and manifest #12160

Closed
wants to merge 33 commits into from
Closed

[vcpkg] Add keyword Supports to Feature in CONTROL file and manifest #12160

wants to merge 33 commits into from

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 30, 2020 •
edited
Loading

Continue to PR #8601, This PR will enable the pipeline to automatically test all features of all ports.

TODO list:

  • Add keyword Supports
  • Handle keywords Supports when parsing Feature
  • Document
  • Test

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Jun 30, 2020
@JackBoosY JackBoosY self-assigned this Jun 30, 2020
@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jun 30, 2020 •
edited
Loading

Note:

  • Feature conflicts need to be considered.
  • Need to consider the default features
  • Features required by dependencies.
  • Only test the features of the modified port.

@strega-nil
Copy link
Contributor

Could you make certain to also add it to manifests? it shouldn't be too terrible, and if you want me to I can also push to this branch.

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Jul 13, 2020 •
edited
Loading

@strega-nil Okay, but it seems that my changes didn't work. Could you please help me?
It seems work now.

Thanks.

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY mentioned this pull request Jul 24, 2020
Merged
@JackBoosY JackBoosY mentioned this pull request Aug 25, 2020
Open
@JackBoosY JackBoosY changed the title [vcpkg] Add keyword Supports to Feature in CONTROL file [vcpkg] Add keyword Supports to Feature in CONTROL file and manifest Sep 9, 2020
@JackBoosY JackBoosY marked this pull request as ready for review September 9, 2020 03:35
@JackBoosY JackBoosY requested a review from BillyONeal September 9, 2020 03:35
@JackBoosY
Copy link
Contributor Author

@ras0219-msft @ras0219 Ping for review this PR.

@PhoebeHui PhoebeHui marked this pull request as draft October 30, 2020 02:43
@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

Close this PR temporary.

@JackBoosY JackBoosY closed this Feb 7, 2021
@JackBoosY JackBoosY deleted the dev/jack/add_supports_to_feature branch June 7, 2021 07:54
@JackBoosY
Copy link
Contributor Author

Already added this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @strega-nil @BillyONeal