[zlib] Add pkgconfig file #12133
Merged
[zlib] Add pkgconfig file #12133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install the zlib.pc file, which is generated during the CMake build. Fix the pkgconfig file under Windows, where the lib is called zlib instead of libz and add the postfix 'd' in case of a Windows debug build.
ras0219
suggested changes
Jun 26, 2020
NancyLi1013
suggested changes
Jun 28, 2020
NancyLi1013
added
requires:author-response
category:port-feature
Co-authored-by: NancyLi1013 <[email protected]>
- Remove include(vcpkg_common_functions) - Comment out vcpkg_test_cmake(PACKAGE_NAME ZLIB MODULE)
c72578
force-pushed
the
2020-06-26_zlib_Add_pkgconfig_file
branch
from
040319e to
76015db
Compare
|
@NancyLi1013, is the PR OK now from your side? |
NancyLi1013
reviewed
Jul 1, 2020
NancyLi1013
approved these changes
Jul 1, 2020
|
@c72578 |
|
The itk failures will be fixed by #11208 |
PhoebeHui
approved these changes
Jul 14, 2020
ras0219
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes #
Install the
zlib.pcfile, which is generated during the CMake build.Fix the pkgconfig file under Windows, where the lib is called
zlibinstead of
libzand add the postfix 'd' in case of a Windows debugbuild.
Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets are supported
Does your PR follow the maintainer guide?
Yes