Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Fix baseline errors #12067

Merged
merged 20 commits into from
Jun 25, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jun 23, 2020

  • Since xmsh REPO is no longer available, set it to an empty port.

Related: #12063 #11637 #12068 etc.

@JackBoosY JackBoosY added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Jun 23, 2020
@JackBoosY
Copy link
Contributor Author

@BillyONeal And The apr-util build failed because port apr archive file installed/x64-osx/build-1/apr_rules.mk cannot be found on the pipeline machine, so I think #11961 should be merged.

@BillyONeal
Copy link
Member

Hmmm should we just delete the port outright rather than letting it successfully 'install' like this?

ports/xmsh/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013
Copy link
Contributor

Related issue #11923

@ras0219-msft
Copy link
Contributor

Since xmsh REPO is no longer available, set it to an empty port.

We should never just be replacing ports with "empty" -- if the port is replaced by something else, it should have a Build-Depends:. In this case, I believe the appropriate path is:

  1. Mark it as skipped
  2. If 6 months pass without a user submitting a fix, we can then remove it.

@BillyONeal
Copy link
Member

pixman:arm64-windows upstream server down during build
quickfix:arm64-windows Not sure exactly what happened, will merge this to nuke tombstone to try again:

D:\buildtrees\quickfix\src\v1.15.1-5086b0da20\src\C++\stdafx.h(14): warning C4005: '_WINSOCK_DEPRECATED_NO_WARNINGS': macro redefinition
D:\buildtrees\quickfix\src\v1.15.1-5086b0da20\src\C++\test\DictionaryTestCase.cpp: note: see previous definition of '_WINSOCK_DEPRECATED_NO_WARNINGS'

itp:x64-windows: upstream server down during build
fontconfig:x86-windows: upstream server down during build
rapidxml:x86-windows: upstream server down during build
itk:x64-osx:

Undefined symbols for architecture x86_64:
  "gdcm::Rescaler::SetMinMaxForPixelType(double, double)", referenced from:
      itk::GDCMImageIO::Write(void const*) in libITKIOGDCM-5.0.a(itkGDCMImageIO.cxx.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

No idea here, it doesn't repro locally. Might be a race in itk's build itself.

fadbad:x64-linux: upstream server down during build.

As a result of the above investigation, merging this.

@BillyONeal BillyONeal merged commit 1f0db1f into microsoft:master Jun 25, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_baseline_20200623 branch June 28, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants