Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSYS2 dependencies #12044

Closed
wants to merge 4 commits into from
Closed

Conversation

emptyVoid
Copy link
Contributor

Describe the pull request

Adds tool-msys metaport to update MSYS2 installation and rebuild the ports using vcpkg_acquire_msys when the latter is changed (it's a maintainer's responsibility to increment the metaport's version when making changes to vcpkg_acquire_msys).

Sets <vcpkg>/downloads directory as an MSYS2 package cache to reuse them after MSYS2 updates.

Additionally introduces PORT_VERSION variable providing access to the version string from port's CONTROL file to CMake scripts.

Waiting on #11836 to conclude, as it introduces a dependency metaport for vcpkg_configure_make which itself is dependent on vcpkg_acquire_msys.

@JackBoosY JackBoosY self-assigned this Jun 22, 2020
@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jun 22, 2020
@cenit
Copy link
Contributor

cenit commented Jun 22, 2020

isn't it better here and in #11836 to just rework the update mechanism and use not just CONTROL version, but also hashes like in CI to verify if update is necessary?
In this way we can avoid this meta port thing, which might "explode" if applied to all tools and toolchains...

@emptyVoid
Copy link
Contributor Author

Well, of course it would be better if the update mechanism checked changes in dependency CMake scripts in addition to CONTROL file. To build the dependency list it would most likely need the portfile's abstract syntax tree which afaik is not publicly accessible, although it should be possible to leverage CMake's sources and cmListFile::ParseFile method directly. But that's a whole 'nother story.

@Neumann-A
Copy link
Contributor

This PR is no longer required since vcpkg now has a heuristic which detects script changes.

@JackBoosY
Copy link
Contributor

I think we don't need this PR now.
If you have any concern, please let me know.

@JackBoosY JackBoosY closed this Aug 10, 2020
@emptyVoid
Copy link
Contributor Author

AFAICT #12254 doesn't take into account transitive dependencies, such as portfile>vcpkg_configure_make>vcpkg_acquire_msys.

@emptyVoid emptyVoid deleted the msys-dependencies branch August 13, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icu] build failure
4 participants