Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg/scripts/make] trying to iron out some issues #11836
[vcpkg/scripts/make] trying to iron out some issues #11836
Changes from 26 commits
3ccd4dd
a0907a1
0cf1aaa
4fcff6c
e9328fe
b9725d7
edf3b24
fc541db
ca25c71
3124ef9
a307a02
8093cf0
eb73911
1bab85b
22bb852
c3413e8
21487d6
35b0d29
c489dc1
d90ae98
9419320
95f4ceb
8be872d
4269503
d20fab1
a194ae9
315d92d
c4caa38
9718a36
c399f28
0a546dd
a7ce732
21e9617
06896bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be fixed instead by producing
.pc
files for curl and usingBased on my reading of https://autotools.io/pkgconfig/pkg_check_modules.html, the default action-if-not-found is to error out.
Otherwise, we should
Build-Depends: openssl
inlibwandio
because it's directly expressing a dependency onopenssl
(e.g. imagine a case of building curl without openssl and thus this would fail).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be a proper fix but I did not want to touch this port any more than necessary. Because every dependency in libwandio would need that fix. If you want I can back out the patches to libwandio.