[vcpkg] Set default triplet depends on architecture (#1254) #11610
Conversation
psionic12
commented
May 27, 2020
psionic12
commented
- Set the environment variable VCPKG_DEFAULT_TRIPLET if it is not set.
- Looking up this environment in CMake to make sure which _VCPKG_TARGET_TRIPLET_ARCH to use.
| # Set Environment Variable "VCPKG_DEFAULT_TRIPLET" depends on architecture | ||
| if(![Environment]::GetEnvironmentVariable("VCPKG_DEFAULT_TRIPLET", "User") -and ![Environment]::GetEnvironmentVariable("VCPKG_DEFAULT_TRIPLET", "Machine")) { | ||
| [Environment]::SetEnvironmentVariable("VCPKG_DEFAULT_TRIPLET", $PreferredToolArchitecture+"-windows", 'User') | ||
| } |
There was a problem hiding this comment.
Doesn't this only set VCPKG_DEFAULT_TRIPLET for the PowerShell instance that runs the bootstrap script?
There was a problem hiding this comment.
No, it sets the environment variable for the user, if replace the "User" to "Process", then it's behavior is what you said. Indeed, it's better to set "Process" as well since the PowerShell instance you run the script will not notice the environment variables are changed.
JackBoosY
added
the
category:vcpkg-feature
|
Thanks for the PR! We don't want to modify the user's outer environment at all in bootstrap; especially not only on one platform. AFAICT the changes to Unless there is something I've missed, I'm going to close this PR for now. Please let us know if there is anything remaining to address! |
