Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VCPKG baseline] Fix many ports #11559

Merged
merged 6 commits into from
May 25, 2020
Merged

[VCPKG baseline] Fix many ports #11559

merged 6 commits into from
May 25, 2020

Conversation

JackBoosY
Copy link
Contributor

Related: #11502.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label May 25, 2020
@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels May 25, 2020
@JackBoosY
Copy link
Contributor Author

JackBoosY commented May 25, 2020 •
edited
Loading

@BillyONeal Could you please take a look?
It seems that geographiclib and libaiff source cannot be downloaded, but I can't repro it on my machine.

For bond:x64-linux regression:

CMake Error at stack_build.cmake:21 (message):
  Preventing creation of stack root '/home/root/.stack/'.  Parent directory
  '/home/root/' is owned by someone else.

I think that's a permission issue.

@BillyONeal
[bond] Workaround /home permissions issue caused by Azure Pipelines c…
3f12322 
…hanging the user under which the agent runs.
@BillyONeal
Copy link
Member

@JackBoosY geographiclib and libaiff are on SourceForge; that service may have chosen a bad mirror when the build tried to download the bits since SourceForge has a large number of mirrors.

I pushed a change which should fix the /home problem.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY marked this pull request as ready for review May 25, 2020 09:56
@JackBoosY
Copy link
Contributor Author

@dan-shaw @strega-nil Please review and merge this PR first.

Thanks.

PhoebeHui
PhoebeHui approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added category:infrastructure Pertaining to the CI/Testing infrastrucutre and removed category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels May 25, 2020
@PhoebeHui PhoebeHui changed the title Fix many ports [VCPKG baseline] Fix many ports May 25, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 25, 2020
This was referenced May 25, 2020
Merged
Merged
@BillyONeal BillyONeal merged commit b271aef into microsoft:master May 25, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix_ci_20200525 branch May 26, 2020 02:07
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request May 26, 2020
@Jimmy-Hu
Merge pull request #220 from microsoft/master
dab6636 
[VCPKG baseline] Fix many ports (microsoft#11559)
@amacgillivray amacgillivray mentioned this pull request May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @BillyONeal @PhoebeHui