Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ace] Add support for uwp #11441

Merged
merged 27 commits into from
May 27, 2020
Merged

[ace] Add support for uwp #11441

merged 27 commits into from
May 27, 2020

Conversation

jwillemsen
Copy link
Contributor

Describe the pull request

  • Which triplets are supported/not supported? Have you updated the CI baseline?

ace:arm-uwp and ace:x64-uwp, should work now

    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/process_manager.patch:
      Added.

    * ports/ace/CONTROL:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/portfile.cmake:
    * ports/ace/process_manager.patch:
    * ports/ace/portfile.cmake:
    * scripts/ci.baseline.txt:
@NancyLi1013 NancyLi1013 self-assigned this May 19, 2020
ports/ace/CONTROL Outdated Show resolved Hide resolved
    * ports/ace/CONTROL:
@jwillemsen jwillemsen requested a review from NancyLi1013 May 19, 2020 10:09
@jwillemsen
Copy link
Contributor Author

Contains the changes from #11369 which I would expect to be merged first

@jwillemsen
Copy link
Contributor Author

Looks arm64_windows failures are not related to my changes

@NancyLi1013
Copy link
Contributor

Yes, this failure is not related with this PR.
You can ignore this. We will resolve this.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

All features have passed with the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 21, 2020
@NancyLi1013
Copy link
Contributor

This PR should be merged after #11369.

@strega-nil strega-nil added the depends:different-pr This PR or Issue depends on a PR which has been filed label May 21, 2020
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 22, 2020
@dan-shaw
Copy link
Contributor

LGTM, can you fix the conflicts from your PR that was just merged?

@jwillemsen
Copy link
Contributor Author

Resolved merge conflicts, thanks for merging the first PR!

@dan-shaw dan-shaw merged commit 7b0789f into microsoft:master May 27, 2020
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:different-pr This PR or Issue depends on a PR which has been filed info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants