Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Rerun libxml2 #11065

Closed

Conversation

NancyLi1013
Copy link
Contributor

llibxml2 failed on osx pipeline in the PR #10770

Undefined symbols for architecture x86_64:
  "_iconv", referenced from:
      _xmlIconvWrapper in libxml2.a(encoding.c.o)
  "_iconv_close", referenced from:
      _xmlFindCharEncodingHandler in libxml2.a(encoding.c.o)
      _xmlCharEncCloseFunc in libxml2.a(encoding.c.o)
  "_iconv_open", referenced from:
      _xmlFindCharEncodingHandler in libxml2.a(encoding.c.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I checked the CMakeLists.txt and found that iconv has been linked. And I also cannot reproduce this on my local.

Related issue #11001.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 28, 2020
@Neumann-A
Copy link
Contributor

Not libxml2 is failing. The port cmake is failing as a depent of libxml2 since it does not know that libxml2 has been linked with iconv. The vcpkg-cmake-wrapper needs to be adjusted to reflect that libxml2 has been build with iconv. This is already done for Windows but not for osx. Just take a look into libxml2 vcpkg-cmake-wrapper and you should directly see it

@NancyLi1013
Copy link
Contributor Author

Thanks for your update.
I understood it now. It is about the usage of libxml2. Will add the dependency later.

@NancyLi1013
Copy link
Contributor Author

After further investigation about this, it seems that this is not a bug for libxml2. So I close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants