[Vcpkg] Fix macOS applocal.py dependency bundling error #11057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same issue and fix applied here OpenZWave/ozw-admin#4.
kevinhartman
changed the title
kevinhartman
changed the title
NancyLi1013
approved these changes
Apr 28, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This is correct, as far as I can tell. I don't know why we weren't decoding before... I wonder if it was getting run in python2? Thanks @kevinhartman :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same issue and fix applied here OpenZWave/ozw-admin#4.
This issue occurs when building a
.appbundle (whenMACOSX_BUNDLEis ON). I believe it's related to Python version or macOS Catalina. Vcpkg is using Python 3.8.1 (validated by print statement within applocal.py itself).Let me know if I can validate anything else. I was hoping to add an automated test for running macOS app package builds, but it looks to me like we don't have automated testing of Vcpkg itself for macOS☹️ .
Describe the pull request
What does your PR fix? Fixes issue #
Currently no open issue, though this is a problem.
Which triplets are supported/not supported? Have you updated the CI baseline?
This is relevant only for macOS. Problem was observed on Catalina (so, 64-bit only).