Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libarchive, libuv]Fix static linkage #10769

Merged
merged 6 commits into from
Apr 17, 2020
Merged

[libarchive, libuv]Fix static linkage #10769

merged 6 commits into from
Apr 17, 2020

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Apr 10, 2020 •
edited
Loading

adds a wrapper to correctly link in dependencies for libarchive and libuv

@Neumann-A Neumann-A changed the title []Fix libarchive libuv static linkage [libarchive, libuv]Fix static linkage Apr 10, 2020
@Neumann-A Neumann-A mentioned this pull request Apr 10, 2020
Merged
2 tasks
@LilyWangL
Copy link
Contributor

include(vcpkg_common_functions) is deprecated in libuv/portfile.cmake. Please remove it.

LilyWangL
LilyWangL suggested changes Apr 13, 2020
View reviewed changes
ports/libarchive/portfile.cmake Show resolved Hide resolved
ports/libuv/portfile.cmake Show resolved Hide resolved
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 14, 2020
ras0219-msft
ras0219-msft requested changes Apr 16, 2020
View reviewed changes
ports/libarchive/portfile.cmake Outdated Show resolved Hide resolved
ports/libarchive/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangL LilyWangL added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 17, 2020
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 17, 2020
@ras0219-msft ras0219-msft merged commit 4d8237b into microsoft:master Apr 17, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@Neumann-A Neumann-A deleted the fix_libarchive_libuv_static_linkage branch April 18, 2020 18:56
@cenit cenit mentioned this pull request Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL requested changes

@ras0219-msft ras0219-msft ras0219-msft requested changes

Assignees

@LilyWangL LilyWangL

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neumann-A @LilyWangL @ras0219-msft