Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[curlpp] Fix target "curlpp" link "ZLIB::ZLIB" error #10535

Merged
merged 4 commits into from
Apr 16, 2020
Merged

[curlpp] Fix target "curlpp" link "ZLIB::ZLIB" error #10535

merged 4 commits into from
Apr 16, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request
Add zlib to default feature, fix curlpp build failed with this error:

CMake Error at D:/Git/vs2019.prod/scripts/buildsystems/vcpkg.cmake:217 (_add_library):
Target "curlpp" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
CMakeLists.txt:89 (add_library)

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 24, 2020
@JackBoosY
Copy link
Contributor

/azp run

@LilyWangL LilyWangL marked this pull request as ready for review March 27, 2020 02:35
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 27, 2020
@dan-shaw dan-shaw added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 28, 2020
@PhoebeHui PhoebeHui mentioned this pull request Apr 7, 2020
Closed
@Neumann-A
Copy link
Contributor

Please change this PR to use the fix discussed in #10715. The problem is not with curl but with curlpp not setting cmake_minimum_required() before the first project() call.

@LilyWangL LilyWangL changed the title [curl] Add zlib to default feature [curlpp] Fix target "curlpp" link "ZLIB::ZLIB" error Apr 7, 2020
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 9, 2020
@JackBoosY JackBoosY mentioned this pull request Apr 13, 2020
Merged
@ras0219-msft ras0219-msft merged commit 4b8ad78 into microsoft:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@dan-shaw dan-shaw dan-shaw approved these changes

Assignees

@JackBoosY JackBoosY

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LilyWangL @JackBoosY @Neumann-A @dan-shaw @ras0219-msft