[vcpkg] Add support for VCPKG_BINARY_SOURCES and --x-binarysource=<> #10476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
added
the
info:internal
ras0219-msft
changed the title
BillyONeal
reviewed
Mar 24, 2020
| @@ -170,6 +185,12 @@ namespace vcpkg | |||
| arg.substr(sizeof("--overlay-triplets=") - 1), "--overlay-triplets", args.overlay_triplets); | |||
| continue; | |||
| } | |||
| if (Strings::starts_with(arg, "--x-binarysource=")) | |||
| { | |||
| parse_cojoined_multivalue( | |||
There was a problem hiding this comment.
substr in this role fills me with sadness but it's consistent with the rest of the code here so feel free to ignore
| { | ||
| if (log_file.path().extension() == ".log") | ||
| // Build failed, store all failure logs in the tombstone. |
There was a problem hiding this comment.
Extract "store tombstone" function rather than commenting?
Avoids conditional expresion is constant warnings
|
/azp run |
|
Pull request contains merge conflicts. |
|
So what does this PR do? Is the design goal to let you point to another directory for cached binaries? |
cbezault
added
the
category:vcpkg-feature
|
Yeah, it enables some configurability for where to look for binaries as well as multi-source and read-only behavior. |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…icrosoft#10476) * [vcpkg] Add support for VCPKG_BINARY_SOURCES and --binarysource=<> * [vcpkg] Rename --binarysource to --x-binarysource to denote internal/experimental * [vcpkg] Address review comments & add tests for BinaryConfigParser * [vcpkg] Replace do {} while(1); with for(;;) Avoids conditional expresion is constant warnings * [vcpkg] Invert if/else * [vcpkg] Fix warning in export.prefab.cpp * [vcpkg] Resolve merge regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.