Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blingfire] Remove uwp support exclusion #31330

Closed
davidmatson opened this issue May 8, 2023 · 0 comments · Fixed by #31331
Closed

[blingfire] Remove uwp support exclusion #31330

davidmatson opened this issue May 8, 2023 · 0 comments · Fixed by #31331
Assignees
@Adela0814
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@davidmatson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'm trying to use this port in a Universal Windows project but cannot because the supports line has !uwp.

Proposed solution

Use Ninja rather than MSBuild to get UWP support.

Describe alternatives you've considered

No response

Additional context

I have a PR to fix this limitation that I hope to submit shortly.
@davidmatson davidmatson added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 8, 2023
@davidmatson davidmatson mentioned this issue May 8, 2023
Merged
7 tasks
dan-shaw pushed a commit that referenced this issue Jun 1, 2023
@davidmatson
Use Ninja rather than MSBuild in BlingFire to support UWP. (#31331)
60f2513 
Fixes #31330.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adela0814 Adela0814

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[blingfire] Use Ninja rather than MSBuild in BlingFire to support UWP.
2 participants
@davidmatson @Adela0814