[glib] Build error #28722
Comments
oleg-derevenetz
added
the
category:port-bug
LilyWangLL
added
requires:repro
|
This file create by the following codes in [GLIB_SOURCE]/glib/meson.build: I saw these files create successfully in log. I can't reproduce this issue locally. I have no idea about why cc @Neumann-A could you please take a look this issue? |
|
Hi @LilyWangLL this is observed in the GitHub CI on |
|
Hmm, I just tried the same build script with the same That's where the issue body for this PR was taken from. |
This one's a race condition in the upstream makefiles, between the gio/win32/ and glib/ subdirectories. My debugging is in wesnoth/wesnoth#7352 (comment) (that PR isn't a fix, it was just to store the logs from the CI). I think this one hasn't been logged or fixed upstream yet; but as I don't do Windows builds locally, I'm not the person to take it upstream. |
|
@stevecotton thanks for providing the info, that the issue is caused by a race condition. |
LilyWangLL
added
depends:upstream-changes
|
Issue submitted upstream: |
It's better to disable them that to get in the habit of ignoring the CI fails from the following two issues; this can be reverted once either is fixed. glib has a bug where it builds things out of order which results in it failing to build the dependencies, which fails the build. microsoft/vcpkg#26601 vcpkg also has a bug where it very often fails to use the cache of the previously built dependencies even if none of them changed, which then makes it rebuild all the dependencies again. microsoft/vcpkg#28722 If the glib bug was fixed, then the errors wouldn't happen since rebuilding the dependencies wouldn't fail. If the caching bug was fixed, then the errors wouldn't happen since it'd just reuse the cached dependencies.
It's better to disable them that to get in the habit of ignoring the CI fails from the following two issues; this can be reverted once either is fixed. glib has a bug where it builds things out of order which results in it failing to build the dependencies, which fails the build. microsoft/vcpkg#28722 vcpkg also has a bug where it very often fails to use the cache of the previously built dependencies even if none of them changed, which then makes it rebuild all the dependencies again. microsoft/vcpkg#26601 If the glib bug was fixed, then the errors wouldn't happen since rebuilding the dependencies wouldn't fail. If the caching bug was fixed, then the errors wouldn't happen since it'd just reuse the cached dependencies.
It's better to disable them that to get in the habit of ignoring the CI fails from the following two issues; this can be reverted once either is fixed. glib has a bug where it builds things out of order which results in it failing to build the dependencies, which fails the build. microsoft/vcpkg#28722 vcpkg also has a bug where it very often fails to use the cache of the previously built dependencies even if none of them changed, which then makes it rebuild all the dependencies again. microsoft/vcpkg#26601 If the glib bug was fixed, then the errors wouldn't happen since rebuilding the dependencies wouldn't fail. If the caching bug was fixed, then the errors wouldn't happen since it'd just reuse the cached dependencies.
It's better to disable them that to get in the habit of ignoring the CI fails from the following two issues; this can be reverted once either is fixed. glib has a bug where it builds things out of order which results in it failing to build the dependencies, which fails the build. microsoft/vcpkg#28722 vcpkg also has a bug where it very often fails to use the cache of the previously built dependencies even if none of them changed, which then makes it rebuild all the dependencies again. microsoft/vcpkg#26601 If the glib bug was fixed, then the errors wouldn't happen since rebuilding the dependencies wouldn't fail. If the caching bug was fixed, then the errors wouldn't happen since it'd just reuse the cached dependencies.
It's better to disable them that to get in the habit of ignoring the CI fails from the following two issues; this can be reverted once either is fixed. glib has a bug where it builds things out of order which results in it failing to build the dependencies, which fails the build. microsoft/vcpkg#28722 vcpkg also has a bug where it very often fails to use the cache of the previously built dependencies even if none of them changed, which then makes it rebuild all the dependencies again. microsoft/vcpkg#26601 If the glib bug was fixed, then the errors wouldn't happen since rebuilding the dependencies wouldn't fail. If the caching bug was fixed, then the errors wouldn't happen since it'd just reuse the cached dependencies.
|
A fix has been prepared upstream: |
LilyWangLL
added
category:port-bug
|
This does not seem to be fixed, since we're still sometimes getting a glib build failure. For example: https://github.com/wesnoth/wesnoth/actions/runs/6012804873/job/16308885150 |
Package: glib[core]:x86-windows -> 2.75.1
Host Environment
vcpkg-scripts version: 0f719b3 2023-01-03 (21 hours ago)
To Reproduce
vcpkg install glibFailure logs
D:\a\fheroes2-prebuilt-deps\fheroes2-prebuilt-deps\.vcpkg\buildtrees\glib\package-x86-windows-rel-out.log
Additional context
gversionmacros.hpresents in thebuildtrees/glib/x86-windows-dbg/glib, but not in thebuildtrees/glib/x86-windows-rel/glib.The text was updated successfully, but these errors were encountered: