Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x264:x64-windows] build failure #13327

Closed
abcping123 opened this issue Sep 3, 2020 · 8 comments · Fixed by #13450
Closed

[x264:x64-windows] build failure #13327

abcping123 opened this issue Sep 3, 2020 · 8 comments · Fixed by #13450
Assignees
@NancyLi1013
Labels
category:port-bug The issue is with a library, which is something the port should already support category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@abcping123
Copy link

Host Environment

  • OS: Windows 10 v1903
  • Compiler: Visual Studio 2017

To Reproduce
Steps to reproduce the behavior:
./vcpkg install x264:x64-windows

It could not cofigure at first, and I find the cause in vcpkg_configure_make.cmake (line 223):
string(REPLACE ";$ENV{SystemRoot}\\System32;" ";${MSYS_ROOT}/usr/share/automake-1.16;${MSYS_ROOT}/usr/bin;$ENV{SystemRoot}\\System32;" NEWPATH "$ENV{PATH}")

This intends to add some paths, however $ENV{PATH} of my system only contains C:\Windows\system32, not C:\Windows\System32, so it fails.

After I modify this, it configures and builds well, but fails again when installing.

install-x64-windows-dbg-err.log
install-x64-windows-dbg-out.log

It seems to be config errors, I have no idea how to fix it after trying some ways, so I come here to seek some help.
@abcping123
Copy link
Author

By the way, environment variables in system setting contains exactly C:\Windows\System32, not C:\Windows\system32.

@NancyLi1013 NancyLi1013 self-assigned this Sep 3, 2020
@abcping123 abcping123 mentioned this issue Sep 4, 2020
Closed
nineKnight referenced this issue Sep 5, 2020
@ras0219 @ras0219-msft
@Neumann-A @BillyONeal
[vcpkg] Replace uses of msys pacman.exe with direct package downloads (…
46e25a1 
…#13019)

* wip

Apply suggestions from code review

Co-authored-by: Alexander Neumann <[email protected]>

* [vcpkg_acquire_msys] Trim list of packages. Introduce defaults.

* [behaviortree-cpp] Fix dynamic dependency on ZMQ

Co-authored-by: Robert Schumacher <[email protected]>
Co-authored-by: Alexander Neumann <[email protected]>
Co-authored-by: Billy Robert O'Neal III <[email protected]>
@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Sep 7, 2020
@NancyLi1013 NancyLi1013 mentioned this issue Sep 10, 2020
Closed
@NancyLi1013
Copy link
Contributor

@Neumann-A
Could you please help take a look?
It seems that there are still some problems when building x264 after PR #11836 merged.

config-x86-wiindows-dbg-out.log

Unknown option --build=x86_64-pc-mingw32, ignored
Unknown option --disable-silent-rules, ignored
Unknown option --verbose, ignored
Unknown option --disable-static, ignored
Unknown system , edit the configure

config-x86-wiindows-dbg-err.log

./../src/14d026c3bd-bca2ebf740/configure: line 327: rm: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 328: rm: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 344: dirname: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 341: dirname: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 345: grep: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 554: /config.sub: No such file or directory
./../src/14d026c3bd-bca2ebf740/configure: line 565: basename: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 148: rm: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 167: cat: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 171: cat: command not found
./../src/14d026c3bd-bca2ebf740/configure: line 1: rm: command not found

@longnguyen2004
Copy link
Contributor

I think it's time for us to switch to ShiftMedia

@ZhengzhongSun
Copy link

I met the same questions now. Is there a stable commit of vcpkg which can be used now?

@Neumann-A
Copy link
Contributor

@longnguyen2004 No, there is no need to do that.

@NancyLi1013 That seems to be an error introduced by @ras0219 changes to MSYS. (see #13327 (comment)). It seems like x264 was forgotten to be removed from the skiplist.

@Neumann-A Neumann-A mentioned this issue Sep 10, 2020
Merged
This was referenced Sep 21, 2020
Closed
Closed
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Sep 24, 2020 •
edited
Loading

This should be fixed by #13450 in master.

@longnguyen2004
Copy link
Contributor

Alright I'll test it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try fixing x264 Neumann-A/vcpkg
7 participants
@ras0219-msft @ZhengzhongSun @longnguyen2004 @abcping123 @Neumann-A @NancyLi1013 and others