Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmp] and [mpir] have irreconcilable conflicts #11756

Closed
BillyONeal opened this issue Jun 3, 2020 · 5 comments · Fixed by #12664
Closed

[gmp] and [mpir] have irreconcilable conflicts #11756

BillyONeal opened this issue Jun 3, 2020 · 5 comments · Fixed by #12664
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@BillyONeal
Copy link
Member

mpir is a fork of the gmp project, and wants to provide the same headers. We have lots of ports that depend on one or the other, so it isn't clear which one is 'more important'. In CI for the next vmss update I'm going to skip mpir (because the header name more closely indicates ownership by gmp) but that's going to break testing of several ports.

PS D:\vcpkg> .\vcpkg.exe install gmp mpir
Computing installation plan...
A suitable version of cmake was not found (required v3.17.2). Downloading portable cmake v3.17.2...
Downloading cmake...
  https://github.com/Kitware/CMake/releases/download/v3.17.2/cmake-3.17.2-win32-x86.zip -> D:\vcpkg\downloads\cmake-3.17.2-win32-x86.zip
Extracting cmake...
A suitable version of 7zip was not found (required v18.1.0). Downloading portable 7zip v18.1.0...
Downloading 7zip...
  https://www.nuget.org/api/v2/package/7-Zip.CommandLine/18.1.0 -> D:\vcpkg\downloads\7-zip.commandline.18.1.0.nupkg
Extracting 7zip...
A suitable version of nuget was not found (required v4.8.1). Downloading portable nuget v4.8.1...
Downloading nuget...
  https://dist.nuget.org/win-x86-commandline/v4.8.1/nuget.exe -> D:\vcpkg\downloads\nuget.exe
The following packages will be built and installed:
    gmp[core]:x86-windows
    mpir[core]:x86-windows
  * vs-yasm[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
A suitable version of powershell-core was not found (required v6.2.1). Downloading portable powershell-core v6.2.1...
Downloading powershell-core...
  https://github.com/PowerShell/PowerShell/releases/download/v6.2.1/PowerShell-6.2.1-win-x86.zip -> D:\vcpkg\downloads\PowerShell-6.2.1-win-x86.zip
Extracting powershell-core...
Starting package 1/3: vs-yasm:x86-windows
Building package vs-yasm[core]:x86-windows...
-- Downloading https://github.com/ShiftMediaProject/VSYASM/archive/deb50d9f18e8461538468339d508cdf240e64897.tar.gz...
-- Extracting source D:/vcpkg/downloads/ShiftMediaProject-VSYASM-deb50d9f18e8461538468339d508cdf240e64897.tar.gz
-- Using source at D:/vcpkg/buildtrees/vs-yasm/src/f240e64897-2c272bd8f3
-- Installing: D:/vcpkg/packages/vs-yasm_x86-windows/share/vs-yasm//yasm.props
-- Installing: D:/vcpkg/packages/vs-yasm_x86-windows/share/vs-yasm//yasm.targets
-- Installing: D:/vcpkg/packages/vs-yasm_x86-windows/share/vs-yasm//yasm.xml
-- Performing post-build validation
-- Performing post-build validation done
Building package vs-yasm[core]:x86-windows... done
Installing package vs-yasm[core]:x86-windows...
Installing package vs-yasm[core]:x86-windows... done
Elapsed time for package vs-yasm:x86-windows: 1.219 s
Starting package 2/3: gmp:x86-windows
Building package gmp[core]:x86-windows...
-- Downloading https://github.com/ShiftMediaProject/gmp/archive/e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz...
-- Extracting source D:/vcpkg/downloads/ShiftMediaProject-gmp-e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz
-- Applying patch vs.build.patch
-- Applying patch runtime.patch
-- Applying patch prefix.patch
-- Using source at D:/vcpkg/buildtrees/gmp/src/adcc6b3cc4-2b6258d695
-- Downloading https://www.tortall.net/projects/yasm/snapshots/v1.3.0.6.g1962/yasm-1.3.0.6.g1962.exe...
-- Installing: D:/vcpkg/downloads/tools/yasm/1.3.0.6/yasm.exe
-- Building SMP/libgmp.sln for Release
-- Building SMP/libgmp.sln for Debug
-- Installing: D:/vcpkg/packages/gmp_x86-windows/share/gmp/copyright
-- Fixing pkgconfig
-- Fixing pkgconfig - release
-- Checking file: D:/vcpkg/packages/gmp_x86-windows/lib/pkgconfig/gmp.pc
-- Checking file: D:/vcpkg/packages/gmp_x86-windows/lib/pkgconfig/gmpxx.pc
-- Fixing pkgconfig - debug
-- Checking file: D:/vcpkg/packages/gmp_x86-windows/debug/lib/pkgconfig/gmp.pc
-- Checking file: D:/vcpkg/packages/gmp_x86-windows/debug/lib/pkgconfig/gmpxx.pc
-- Fixing pkgconfig --- finished
-- Performing post-build validation
-- Performing post-build validation done
Building package gmp[core]:x86-windows... done
Installing package gmp[core]:x86-windows...
Installing package gmp[core]:x86-windows... done
Elapsed time for package gmp:x86-windows: 1.164 min
Starting package 3/3: mpir:x86-windows
Building package mpir[core]:x86-windows...
-- Downloading https://github.com/wbhart/mpir/archive/mpir-3.0.0.tar.gz...
-- Extracting source D:/vcpkg/downloads/wbhart-mpir-mpir-3.0.0.tar.gz
-- Applying patch enable-runtimelibrary-toggle.patch
-- Using source at D:/vcpkg/buildtrees/mpir/src/mpir-3.0.0-c9f63a8302
-- Building D:/vcpkg/buildtrees/mpir/x86-windows/build.vc14/dll_mpir_gc/dll_mpir_gc.vcxproj for Release
-- Building D:/vcpkg/buildtrees/mpir/x86-windows/build.vc14/dll_mpir_gc/dll_mpir_gc.vcxproj for Debug
-- Performing post-build validation
-- Performing post-build validation done
Building package mpir[core]:x86-windows... done
Installing package mpir[core]:x86-windows...
The following files are already installed in D:/vcpkg/installed/x86-windows and are in conflict with mpir:x86-windows

Installed by gmp:x86-windows
    include/gmp.h
    include/gmpxx.h

Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: mpir:x86-windows
  Vcpkg version: 2020.02.04-nohash

Additionally, attach any relevant sections from the log files above.
PS D:\vcpkg>
@BillyONeal BillyONeal added the category:port-bug The issue is with a library, which is something the port should already support label Jun 3, 2020
BillyONeal added a commit to BillyONeal/vcpkg that referenced this issue Jun 3, 2020
@Neumann-A
Copy link
Contributor

Neumann-A commented Jun 4, 2020

As I already said in another PR

set(OPTIONS --disable-silent-rules --enable-gmpcompat --enable-cxx ${SHARED_STATIC})

Try to remove --enable-gmpcompat and make mpir depend on gmp

@BillyONeal
Copy link
Member Author

As I already said in another PR

set(OPTIONS --disable-silent-rules --enable-gmpcompat --enable-cxx ${SHARED_STATIC})

Try to remove --enable-gmpcompat and make mpir depend on gmp

I saw the conflict on Windows which doesn't use that command line at all.

@JackBoosY
Copy link
Contributor

How about just remove these conflict files?

@JackBoosY
Copy link
Contributor

No, I think they just conflict with each other.
From official documentation:

MPIR is a highly optimised library for bignum arithmetic forked from the GMP bignum library.

@BillyONeal
Copy link
Member Author

Right, they are alternatives like openssl and boringssl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
4 participants