Skip to content

Commit

Permalink
[cryptopp] fix build by disabling assembly on osx (#6821)
Browse files Browse the repository at this point in the history
* [cryptopp] fix build by disabling assembly on osx

* [cryptopp] Bump control version
  • Loading branch information
jhs67 authored and ras0219-msft committed Jun 9, 2019
1 parent 4c898ff commit e2d5324
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ports/cryptopp/CONTROL
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Source: cryptopp
Version: 8.1.0
Version: 8.1.0-1
Description: Crypto++ is a free C++ class library of cryptographic schemes.
9 changes: 9 additions & 0 deletions ports/cryptopp/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ vcpkg_from_github(
file(COPY ${CMAKE_SOURCE_PATH}/cryptopp-config.cmake DESTINATION ${SOURCE_PATH})
file(COPY ${CMAKE_SOURCE_PATH}/CMakeLists.txt DESTINATION ${SOURCE_PATH})

# disable assembly on OSX to fix broken build
if(APPLE)
set(CRYPTOPP_DISABLE_ASM "ON")
else()
set(CRYPTOPP_DISABLE_ASM "OFF")
endif()


# Dynamic linking should be avoided for Crypto++ to reduce the attack surface,
# so generate a static lib for both dynamic and static vcpkg targets.
# See also:
Expand All @@ -40,6 +48,7 @@ vcpkg_configure_cmake(
-DBUILD_STATIC=ON
-DBUILD_TESTING=OFF
-DBUILD_DOCUMENTATION=OFF
-DDISABLE_ASM=${CRYPTOPP_DISABLE_ASM}
)

vcpkg_install_cmake()
Expand Down

0 comments on commit e2d5324

Please sign in to comment.