Address review comments

microsoft · May 18, 2023 · d6e911a · d6e911a
1 parent 3c437e2
commit d6e911a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/ports/gsl/CMakeLists.txt b/ports/gsl/CMakeLists.txt
@@ -41,9 +41,8 @@ endforeach()
 
 file(READ gsl_types.h GSLTYPES_H)
 if(WIN32)
-    string(REPLACE "#ifdef WIN32" "#if 1 /*WIN32*/" GSLTYPES_H "${GSLTYPES_H}")
     if(BUILD_SHARED_LIBS)
-        string(REPLACE "#  ifdef GSL_DLL" "#  if 1 /*GSL_DLL*/" GSLTYPES_H "${GSLTYPES_H}")
+        target_compile_definitions(gsl PRIVATE GSL_DLL)
     endif()
 endif(WIN32)
 file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/gsl_types.h "${GSLTYPES_H}")