Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x-download] teach to not need a sha512 #142

Merged
merged 5 commits into from
Jul 30, 2021
Merged

[x-download] teach to not need a sha512 #142

merged 5 commits into from
Jul 30, 2021

Conversation

strega-nil
Copy link
Contributor

No description provided.

@strega-nil
Billy CRs
0f753a0 
plus minor Robert CR
ras0219-msft
ras0219-msft approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, though I don't especially like significant ceremony and boilerplate of struct Sha512Check compared to a flat Optional<std::string>.

@strega-nil-ms
Copy link
Contributor

@ras0219-msft I'm okay either way; @BillyONeal which would you rather?

@strega-nil-ms strega-nil-ms force-pushed the x-download-skip-sha512 branch from f4e0200 to 9195a3a Compare July 29, 2021 22:32
strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Jul 29, 2021
@strega-nil
[scripts-audit] vcpkg_download_distfile
2b71a8e 
depends on PR microsoft/vcpkg-tool#142
@strega-nil strega-nil mentioned this pull request Jul 29, 2021
Closed
@BillyONeal
Copy link
Member

Thanks!

@BillyONeal BillyONeal merged commit 1e4448e into microsoft:main Jul 30, 2021
@strega-nil-ms strega-nil-ms deleted the x-download-skip-sha512 branch January 4, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms left review comments

@ras0219-msft ras0219-msft ras0219-msft approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strega-nil @strega-nil-ms @BillyONeal @ras0219-msft