Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x-update-baseline to use reference field #1414

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

data-queue
Copy link
Contributor

Invoking x-update-baseline incorrectly updates the baseline field when the registry is configured with a reference. The correct behavior is to use the latest commit of the reference branch when set.

See microsoft/vcpkg#38701

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@BillyONeal BillyONeal merged commit f09af89 into microsoft:main Jun 14, 2024
4 of 5 checks passed
@BillyONeal
Copy link
Member

I merged through the formatting check with admin privs because there was a clean run and the only edit afterwards added a trailing newline.

Format failures fixed in #1433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants