Add Campaign IDs #1408
Merged
Add Campaign IDs #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
previously requested changes
May 29, 2024
|
I think we should ship this before setting up telemetry for this. The reason being that we don't even know whether or not people will click on these links. We could be investing resources into setting up telemetry for no reason. |
|
Thanks! |
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Jun 26, 2024
Between: * microsoft#1210 * microsoft#1408 This adds the URL to normal registries use of this but doesn't repeat the URL over and over again in ci-verify-versions.
BillyONeal
added a commit
that referenced
this pull request
Jun 27, 2024
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Jul 24, 2024
* In microsoft#1455 I missed making absolute lowercase. * In microsoft#1408 a lot of whitespace was missed leading to output like error: building vtk:x64-linux failed with: BUILD_FAILEDSee https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
BillyONeal
added a commit
that referenced
this pull request
Jul 24, 2024
* In #1455 I missed making absolute lowercase. * In #1408 a lot of whitespace was missed leading to output like error: building vtk:x64-linux failed with: BUILD_FAILEDSee https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding some campaign ids to some of our commands. Rather than doing all at once, I'm hoping to break things down into chunks in separate PRs. The aim for this PR is to ensure the Campaign IDs are working by testing out a few links.