Delete BuildInfo::version. #1259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the only place this was used, create_binary_control_file, the version is passed in via the constructor of BinaryParagraph:
```� BinaryParagraph::BinaryParagraph(const SourceParagraph& spgh,
const std::vector<std::string>& default_features,
Triplet triplet,
const std::string& abi_tag,
std::vector<PackageSpec> deps)
: spec(spgh.name, triplet)
, version(spgh.raw_version)
, port_version(spgh.port_version)
, description(spgh.description)
, maintainers(spgh.maintainers)
, feature()
, default_features(default_features)
, dependencies(std::move(deps))
, abi(abi_tag)
{
canonicalize();
}
```
| @@ -617,10 +616,7 @@ namespace vcpkg | |||
| action.spec.triplet(), | |||
| action.public_abi(), | |||
| fspecs_to_pspecs(find_itr->second)); | |||
| if (const auto p_ver = build_info.version.get()) | |||
| { | |||
| bpgh.version = *p_ver; | |||
There was a problem hiding this comment.
This records the fetched source version when users use --head: https://github.com/microsoft/vcpkg/blob/0e2a0e0ad1a370f85a637452be52e2ddf2dcac0b/scripts/build_info.cmake#L44-L46
Arguably this should probably be a combination (+=) and not a replacement
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Nov 1, 2023
BillyONeal
added a commit
that referenced
this pull request
Nov 3, 2023
* Add test case for the recording head version feature noted in #1259 (comment) * Sanitize detected head versions to make sure they are at least version-strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the only place this was used, create_binary_control_file, the version is passed in via the constructor of BinaryParagraph: