-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcpkg add port: Handle feature core. #1163
Conversation
ac43244
to
c9c8b1c
Compare
"dependencies": [ | ||
{ | ||
"name": "sqlite3", | ||
"default-features": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be clarified that this is still here from the previous run, but it would also be better to have an independent test with [core,somethingelse]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought I think this should make default features be true because that's what sqlite3[zlib]
requests.
@ras0219-msft also points out that we should have tests for multiple references to the same name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now have the test vcpkg add port "sqlite3" "sqlite3[core]"
@AugP @vicroms @dan-shaw @ras0219-msft @JavierMatosD and I discussed this today and it gets design approval modulo the nitpicks above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a merge with main for you; do you want me to fix the behavior bit I pointed out for you here and merge?
Sorry for the late answer. Yeah you could have done that 😅 I have not implemented this |
Thanks! |
Don't crash at
vcpkg add port sqlite3[core]
Now sets
"default-featues": false