Allow overrides to select ports that aren't in the baseline. #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename patterns.ps1 to e2e-registry.ps1, to reflect that there are tests for more than just patterns now. * Add removed.json.in and a call to it. See also microsoft#1108 which fixes all the e2e infrastructure to consistently use -s.
…tFileProvider is suspect. In this case it was:
```
void load_tag_vars(const ActionPlan& action_plan,
const PortFileProvider& port_provider,
Triplet host_triplet) const;
```
Fix that by just pushing the ActionPlan part down to the underlying virtual load_tag_vars.
ras0219-msft
approved these changes
Jun 23, 2023
vicroms
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always intended to work but did not. We have been 'removing' the ports from our curated index assuming that this worked anyway.
The crux of the issue is that load_tag_vars would attempt to reload the port after the action plan had already been constructed in a version oblivious way.
See also #1108