Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error message when cadl-server is not found in Visual Studio #594

Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jun 7, 2022

fix #507

Visual studio 2022

image

clicking on notifications provide you with
image

VSCode

Notification
image
On output window
image

Bonus: progress when starting
image

@timotheeguerin timotheeguerin force-pushed the fix/vs-cadl-server-not-found branch from d313663 to 51481f4 Compare June 7, 2022 21:07
@timotheeguerin timotheeguerin marked this pull request as ready for review June 7, 2022 21:17
@azure-pipelines
Copy link

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/594/

@timotheeguerin timotheeguerin changed the title [WIP] Add better error message when cadl-server is not found in Visual Studio Add better error message when cadl-server is not found in Visual Studio Jun 7, 2022
Copy link
Contributor

@nguerrera nguerrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few minor things.

packages/cadl-vs/src/Exceptions.cs Outdated Show resolved Hide resolved
packages/cadl-vs/src/Exceptions.cs Outdated Show resolved Hide resolved
packages/cadl-vs/src/VSExtension.cs Outdated Show resolved Hide resolved
packages/cadl-vs/src/VSExtension.cs Outdated Show resolved Hide resolved
packages/cadl-vscode/src/extension.ts Outdated Show resolved Hide resolved
@timotheeguerin timotheeguerin merged commit 73c8bf7 into microsoft:main Jun 8, 2022
@timotheeguerin timotheeguerin deleted the fix/vs-cadl-server-not-found branch July 26, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants