Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TupleExpression #5021

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Conversation

live1206
Copy link
Contributor

@live1206 live1206 commented Nov 8, 2024

Resolves #5019

Implement TupleExpression and VariableTupleExpression

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 8, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp

@live1206
Copy link
Contributor Author

live1206 commented Nov 8, 2024

Realized this is not enough for tuple support.
There are more things needs to be done:

  • need VariableTupleExpression to be able to define a tuple
  • probably define multiple ParameterProvider and unify them into a VariableTupleExpression

@live1206 live1206 marked this pull request as draft November 8, 2024 08:37
@live1206 live1206 marked this pull request as ready for review November 8, 2024 09:01
@live1206 live1206 added this pull request to the merge queue Nov 11, 2024
Merged via the queue into microsoft:main with commit c7dc05a Nov 11, 2024
21 checks passed
@live1206 live1206 deleted the tuple-expression branch November 11, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TupleExpression
5 participants