Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Typespec Language Server when it's not started before or settings changed #4912

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

RodgeFu
Copy link
Contributor

@RodgeFu RodgeFu commented Oct 30, 2024

  1. TypeSpec Language Server would be restarted with new settings when setting "typespec.tsp-server.path" is changed
  2. Typespec Language Server can be restarted properly when the server wasn't running before
  3. Code refactor in vscode extension.

related issues:
#2996, #4765

@RodgeFu RodgeFu added the ide Issues for VS, VSCode, Monaco, etc. label Oct 30, 2024
@RodgeFu RodgeFu changed the title Typespec Language Server restart when it's not started before or settings changed Restart Typespec Language Server when it's not started before or settings changed Oct 30, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 30, 2024

All changed packages have been documented.

  • typespec-vscode
Show changes

typespec-vscode - fix ✏️

Fix the issue when Typespec Language Server can't be restarted when the server wasn't running before

typespec-vscode - feature ✏️

TypeSpec Language Server would be restarted with new settings when setting "typespec.tsp-server.path" is changed

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@RodgeFu
Copy link
Contributor Author

RodgeFu commented Oct 31, 2024

@timotheeguerin , the build in ci failed because of error "SyntaxError: Octal escape sequences are not allowed in strict mode.", but I didn't use any Octal escape sequences and the build can pass properly in my local. Do you have any idea about it? or do you know any change in CI recently that may trigger it? thanks.

image

@timotheeguerin
Copy link
Member

@timotheeguerin , the build in ci failed because of error "SyntaxError: Octal escape sequences are not allowed in strict mode.", but I didn't use any Octal escape sequences and the build can pass properly in my local. Do you have any idea about it? or do you know any change in CI recently that may trigger it? thanks.

image

yeah not sure works for me locally too

@timotheeguerin
Copy link
Member

only seems to fail on windows, probably why I can't repro

@timotheeguerin
Copy link
Member

timotheeguerin commented Oct 31, 2024

ok so I fixed it by reverting the use of import.meta.dirname seems to be some issues there where it probably replace it with the windows path and thinks there is some octal escape sequence rollup/rollup#3260

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 31, 2024
Merged via the queue into microsoft:main with commit 81c83dd Oct 31, 2024
22 checks passed
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
…ings changed (microsoft#4912)

1. TypeSpec Language Server would be restarted with new settings when
setting "typespec.tsp-server.path" is changed
2. Typespec Language Server can be restarted properly when the server
wasn't running before
3. Code refactor in vscode extension.

related issues:
microsoft#2996, microsoft#4765

---------

Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants