Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Enum-driven visibility #4825

Merged

Conversation

witemple-msft
Copy link
Member

@witemple-msft witemple-msft commented Oct 22, 2024

This PR implements the design described in the Enum-Driven Visibility rework discussions.

There is still some work to be done:

  • Testing of new functionality (existing tests are almost all passing)
  • Diagnosing remaining failure w.r.t. Resource create operations in TypeSpec/REST
  • Validate no breaking changes to Azure specifications.
  • Documentation review and updating existing visibility documentation to describe new behavior.

The design documents are located at the following gist: https://gist.github.com/witemple-msft/f122c1fce83e72d102290b5678930ac5

@witemple-msft witemple-msft added the compiler:core Issues for @typespec/compiler label Oct 22, 2024
@witemple-msft witemple-msft self-assigned this Oct 22, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 22, 2024

All changed packages have been documented.

  • @typespec/compiler
  • @typespec/http
  • @typespec/openapi
Show changes

@typespec/compiler - feature ✏️

Adds support for enum-driven visibility in the compiler core.

@typespec/http - internal ✏️

Mask deprecation on getVisibility

@typespec/openapi - internal ✏️

Mask deprecation on getVisibility

@markcowl
Copy link
Contributor

Is there an uptake PR into typespec-azure?

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@witemple-msft
Copy link
Member Author

tsv passing: Azure/azure-rest-api-specs#31469

@witemple-msft
Copy link
Member Author

typespec-azure passing: Azure/typespec-azure#1829

@witemple-msft witemple-msft added this pull request to the merge queue Nov 7, 2024
Merged via the queue into microsoft:main with commit 050139d Nov 7, 2024
23 checks passed
@witemple-msft witemple-msft deleted the witemple-msft/visibility-enum branch November 7, 2024 23:36
github-merge-queue bot pushed a commit to Azure/typespec-azure that referenced this pull request Nov 8, 2024
This PR is for validation of the uptake of
microsoft/typespec#4825

It masks some no-deprecated lint errors that result from the deprecation
of `getVisibility`

---------

Co-authored-by: Will Temple <[email protected]>
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Dec 5, 2024
This PR is for validation of the uptake of
microsoft/typespec#4825

It masks some no-deprecated lint errors that result from the deprecation
of `getVisibility`

---------

Co-authored-by: Will Temple <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:core Issues for @typespec/compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants