-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Enum-driven visibility #4825
Merged
witemple-msft
merged 37 commits into
microsoft:main
from
witemple-msft:witemple-msft/visibility-enum
Nov 7, 2024
Merged
[compiler] Enum-driven visibility #4825
witemple-msft
merged 37 commits into
microsoft:main
from
witemple-msft:witemple-msft/visibility-enum
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witemple-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
October 22, 2024 17:58
All changed packages have been documented.
|
…nto witemple-msft/visibility-enum
Is there an uptake PR into typespec-azure? |
You can try these changes here
|
tsv passing: Azure/azure-rest-api-specs#31469 |
typespec-azure passing: Azure/typespec-azure#1829 |
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Nov 8, 2024
This PR is for validation of the uptake of microsoft/typespec#4825 It masks some no-deprecated lint errors that result from the deprecation of `getVisibility` --------- Co-authored-by: Will Temple <[email protected]>
This was referenced Nov 14, 2024
markcowl
pushed a commit
to markcowl/typespec-azure
that referenced
this pull request
Dec 5, 2024
This PR is for validation of the uptake of microsoft/typespec#4825 It masks some no-deprecated lint errors that result from the deprecation of `getVisibility` --------- Co-authored-by: Will Temple <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the design described in the Enum-Driven Visibility rework discussions.
There is still some work to be done:
The design documents are located at the following gist: https://gist.github.com/witemple-msft/f122c1fce83e72d102290b5678930ac5